Add documentation for the -Zself-profile flag
#69220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
nice work. shall there maybe also be some short description of the -Zself_profile_events? |
wesleywiser
force-pushed
the
doc_self_profile_unstable_book
branch
from
9653640 to
58ec5d2
Compare
|
@andjo403 Yeah, that's a good idea! |
|
this looks amazing |
|
Thanks! |
src/doc/unstable-book/src/compiler-flags/self-profile-events.md
Outdated
Show resolved
Hide resolved
src/doc/unstable-book/src/compiler-flags/self-profile-events.md
Outdated
Show resolved
Hide resolved
src/doc/unstable-book/src/compiler-flags/self-profile-events.md
Outdated
Show resolved
Hide resolved
|
|
||
| - `function-args` | ||
| - Adds additional tracing data to some `generic-activity` events. | ||
| - Disabled by default for parity with `query-keys`. |
There was a problem hiding this comment.
off-topic: we should measure if enabling this by default adds noticeable overhead.
|
Looks great! I left a few minor suggestions. |
wesleywiser
force-pushed
the
doc_self_profile_unstable_book
branch
from
58ec5d2 to
5b7e6c0
Compare
|
Thanks @michaelwoerister! I applied your suggestions. |
nikomatsakis
approved these changes
Feb 24, 2020
|
@bors r+ rollup |
|
📌 Commit 5b7e6c0 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=always Just edits documentation, low risk. |
|
Thanks @nikomatsakis! Once this lands, I'll update the blog post to link to these docs, update the post date and then we'll be ready to post it. |
bors
added a commit
that referenced
this pull request
Feb 25, 2020
Rollup of 6 pull requests Successful merges: - #69220 (Add documentation for the `-Zself-profile` flag) - #69391 (Add rustdoc aliases to `ptr::copy` and `ptr::copy_nonoverlapping`) - #69427 (Cleanup e0368 e0369) - #69433 (don't explicitly compare against true or false) - #69435 (Replace uses of Cell::get + Cell::set with Cell::replace.) - #69437 (no more codegen for miri_start_panic) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.