Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ping PR reviewers in toolstate breakage #69449

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Do not ping PR reviewers in toolstate breakage #69449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/tools/publish_toolstate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ def issue(
assignees,
relevant_pr_number,
relevant_pr_user,
pr_reviewer,
):
# Open an issue about the toolstate failure.
if status == 'test-fail':
Expand All @@ -147,11 +146,11 @@ def issue(
cc @{}, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @{}, the PR reviewer, and nominating for compiler team prioritization.
And nominating for compiler team prioritization.

''').format(
relevant_pr_number, tool, status_description,
REPOS.get(tool), relevant_pr_user, pr_reviewer
REPOS.get(tool), relevant_pr_user
)),
'title': '`{}` no longer builds after {}'.format(tool, relevant_pr_number),
'assignees': list(assignees),
Expand Down Expand Up @@ -236,7 +235,7 @@ def update_latest(
try:
issue(
tool, create_issue_for_status, MAINTAINERS.get(tool, ''),
relevant_pr_number, relevant_pr_user, pr_reviewer,
relevant_pr_number, relevant_pr_user,
)
except urllib2.HTTPError as e:
# network errors will simply end up not creating an issue, but that's better
Expand Down