update miri

[RalfJung]

Let's make that toolstate green again. :D

This bumps serde in the lockfile, so r? @oli-obk

Fixes #69462

[rust-highfive]

⚠️ Warning ⚠️

• These commits modify submodules.

[Aaron1011]

@RalfJung: It looks like bootstrap is passing cargo-miri the path of xargo rather than xargo-check:

rust/src/bootstrap/test.rs

Line 394 in 18c275b

cargo.env("XARGO", builder.out.join("bin").join("xargo"));

This causes us to end up using xargo instead of xargo-check, resulting in codegen being run for panic_unwind.

Since cargo-miri now only invokes xargo-check (never xargo), we should probably rename this environment variable to XARGO_CHECK, and set it to the path of xargo-check in bootstrap.

[Aaron1011]

@RalfJung: I've opened rust-lang/miri#1201. Once it's merged, you should be able to update src/bootstrap/test.rs to set XARGO_CHECK to the proper path.

[RalfJung]

@Aaron1011 great catch! That's most likely it. Thanks :)

[nikomatsakis]

@bors r+

[bors]

📌 Commit 3ab227f5f0e61938a2ebfb1f5d1d600785a5e04d has been approved by nikomatsakis

[RalfJung]

@bors p=1

[bors]

⌛ Testing commit 3ab227f5f0e61938a2ebfb1f5d1d600785a5e04d with merge d2b5382efc49474dee6795da63c8548f08982a46...

[bors]

💔 Test failed - checks-azure

[RalfJung]

This is some kind of cargo feature issue:

2020-03-04T04:08:54.5742630Z duplicate artifacts found when compiling a tool, this typically means that something was recompiled because a transitive dependency has different features activated than in a previous build:
2020-03-04T04:08:54.5743350Z 
2020-03-04T04:08:54.5743800Z the following dependencies are duplicated although they have the same features enabled:
2020-03-04T04:08:54.5744250Z the following dependencies have different features:
2020-03-04T04:08:54.5745550Z   proc-macro2 0.4.30 (registry+https://github.com/rust-lang/crates.io-index)
2020-03-04T04:08:54.5746790Z     `rustfmt` additionally enabled features {"default"} at "/Users/runner/runners/2.165.0/work/1/s/build/x86_64-apple-darwin/stage1-tools/x86_64-apple-darwin/release/deps/libproc_macro2-58288f9f59724080.rlib"
2020-03-04T04:08:54.5748230Z     `cargo` additionally enabled features {} at "/Users/runner/runners/2.165.0/work/1/s/build/x86_64-apple-darwin/stage1-tools/x86_64-apple-darwin/release/deps/libproc_macro2-ad9101f6f50fce55.rlib"
2020-03-04T04:08:54.5749280Z   quote 0.6.12 (registry+https://github.com/rust-lang/crates.io-index)
2020-03-04T04:08:54.5750460Z     `rustfmt` additionally enabled features {"default"} at "/Users/runner/runners/2.165.0/work/1/s/build/x86_64-apple-darwin/stage1-tools/x86_64-apple-darwin/release/deps/libquote-d6c8c62334473aa9.rlib"
2020-03-04T04:08:54.5751860Z     `cargo` additionally enabled features {} at "/Users/runner/runners/2.165.0/work/1/s/build/x86_64-apple-darwin/stage1-tools/x86_64-apple-darwin/release/deps/libquote-571fc6c253801dac.rlib"
2020-03-04T04:08:54.5752910Z   syn 0.15.35 (registry+https://github.com/rust-lang/crates.io-index)
2020-03-04T04:08:54.5754070Z     `rustfmt` additionally enabled features {"visit"} at "/Users/runner/runners/2.165.0/work/1/s/build/x86_64-apple-darwin/stage1-tools/x86_64-apple-darwin/release/deps/libsyn-7a2f4a52e285b5df.rlib"
2020-03-04T04:08:54.5756090Z     `cargo` additionally enabled features {} at "/Users/runner/runners/2.165.0/work/1/s/build/x86_64-apple-darwin/stage1-tools/x86_64-apple-darwin/release/deps/libsyn-61f655d09c570865.rlib"

These days, is there a better way to debug those than random guessing?

[RalfJung]

I think what's happening is that fewer things use the old syn now, and that changes the features it gets, and they are not consistently the same features everywhere... what a pain.

I will just downgrade serde_json in miri so that I don't have to touch the lockfile here, and hope that someone with a better clue for rustc dependencies resolves this eventually.^^

[RalfJung]

@bors r=nikomatsakis

[bors]

📌 Commit faf3a5e has been approved by nikomatsakis

[bors]

⌛ Testing commit faf3a5e with merge 2b0cfa5...

[bors]

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 2b0cfa5 to master...

[rust-highfive]

📣 Toolstate changed by #69636!

Tested on commit 2b0cfa5.
Direct link to PR: #69636

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).