Rewrite Parser::collect_tokens
#72393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
Aaron1011
force-pushed
the
feature/rewrite-collect-tokens
branch
from
ab6f593 to
1b9da36
Compare
|
@petrochenkov: Updated |
Aaron1011
added
S-waiting-on-review
|
r=me after squashing commits |
petrochenkov
added
S-waiting-on-author
The previous implementation did not work when called on an opening delimiter, or when called re-entrantly from the same `TokenCursor` stack depth.
Aaron1011
force-pushed
the
feature/rewrite-collect-tokens
branch
from
f768cd3 to
52bb09a
Compare
|
@bors r=petrochenkov |
|
📌 Commit 52bb09a has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 52bb09a with merge c4cb65167c4a3f89c7dfd427186203b675185633... |
|
💔 Test failed - checks-azure |
|
@bors retry |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 23, 2020
…okens, r=petrochenkov Rewrite `Parser::collect_tokens` The previous implementation did not work when called on an opening delimiter, or when called re-entrantly from the same `TokenCursor` stack depth. I'm not sure how to test this apart from rust-lang#72287
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 24, 2020
Rollup of 3 pull requests Successful merges: - rust-lang#72284 (Remove `macro_defs` map) - rust-lang#72393 (Rewrite `Parser::collect_tokens`) - rust-lang#72528 (Fix typo in doc comment.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation did not work when called on an opening
delimiter, or when called re-entrantly from the same
TokenCursorstackdepth.
I'm not sure how to test this apart from #72287