-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debug assertion in typeck #72714
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Regression test for #72410, this should be used with debug assertion enabled. | ||
|
||
// should be fine | ||
pub trait Foo { | ||
fn map() | ||
where | ||
Self: Sized, | ||
for<'a> &'a mut [u8]: ; | ||
} | ||
|
||
// should fail | ||
pub trait Bar { | ||
fn map() | ||
where for<'a> &'a mut [dyn Bar]: ; | ||
//~^ ERROR: the trait `Bar` cannot be made into an object | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
error[E0038]: the trait `Bar` cannot be made into an object | ||
--> $DIR/issue-72410.rs:14:19 | ||
| | ||
LL | pub trait Bar { | ||
| --- this trait cannot be made into an object... | ||
LL | fn map() | ||
| --- ...because associated function `map` has no `self` parameter | ||
LL | where for<'a> &'a mut [dyn Bar]: ; | ||
| ^^^^^^^^^^^^^^^^^ the trait `Bar` cannot be made into an object | ||
| | ||
help: consider turning `map` into a method by giving it a `&self` argument or constraining it so it does not apply to trait objects | ||
| | ||
LL | where for<'a> &'a mut [dyn Bar]:, Self: Sized ; | ||
| ^^^^^^^^^^^^^ | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0038`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a test for a type that is not WF, which this PR would allow compiling, but we'd never want to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we separate that test in an another file? And I'm not sure what kind of test case is appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something like
which I think ought to fail because
dyn Foo<'a>: Sized
doesn't holdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could add it in the same file I suppose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Niko! Added it.