Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use outermost invocation span for doctest names #73842

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Use outermost invocation span for doctest names #73842

merged 2 commits into from
Aug 7, 2020

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jun 28, 2020

Fixes #70090.

This PR also allows using aux-build files in rustdoc-ui tests.

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2020
@euclio euclio mentioned this pull request Jun 29, 2020
Merged
@Muirrum Muirrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2020
@ollie27 ollie27 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 24, 2020
@JohnTitor
Copy link
Member

Ping from triage: @GuillaumeGomez Could you take a look? This hasn't got any response for a month.

GuillaumeGomez
GuillaumeGomez approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeGomez
Copy link
Member

Sorry, completely missed it... Thanks a lot @euclio!

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 7, 2020

📌 Commit 6088079 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2020
@bors
Copy link
Contributor

bors commented Aug 7, 2020

⌛ Testing commit 6088079 with merge 1e0e618...

@bors
Copy link
Contributor

bors commented Aug 7, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: GuillaumeGomez
Pushing 1e0e618 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2020
@bors bors merged commit 1e0e618 into rust-lang:master Aug 7, 2020
@euclio euclio deleted the doctest-expn branch August 7, 2020 14:11
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
@moxian moxian mentioned this pull request Mar 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

Ungreat change to doctest test names
8 participants
@euclio @rust-highfive @JohnTitor @GuillaumeGomez @bors @cuviper @ollie27 @Muirrum