Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize deque_make_contiguous #74559

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Stabilize deque_make_contiguous #74559

merged 3 commits into from
Sep 1, 2020
+8 −5

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented Jul 20, 2020

Closes #70929.

/cc @Amanieu

@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2020
@jonhoo
Copy link
Contributor Author

jonhoo commented Jul 20, 2020

(I cc'ed Amanieu after a brief conversation with him on Zulip where he told me to post this)

@jonhoo jonhoo mentioned this pull request Jul 20, 2020
Closed
2 tasks
@Amanieu Amanieu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 20, 2020
@Amanieu
Copy link
Member

Amanieu commented Jul 20, 2020

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jul 20, 2020 •
edited by sfackler
Loading

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 20, 2020
@Amanieu Amanieu assigned Amanieu and unassigned withoutboats Jul 20, 2020
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 20, 2020
@jonas-schievink jonas-schievink added this to the 1.47 milestone Jul 20, 2020
@bors
Copy link
Contributor

bors commented Jul 28, 2020

☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts.

@jonhoo jonhoo force-pushed the stabilize-vecdeque-make_contiguous branch from 37bbbae to 2f96ce8 Compare July 28, 2020 12:37
@jonhoo
Copy link
Contributor Author

jonhoo commented Aug 3, 2020

Gentle ping on this. Should hopefully not be too controversial, and it'd be great to try to get it onto the release train :)

@Amanieu
Copy link
Member

Amanieu commented Aug 6, 2020

ping for checkboxes @SimonSapin @withoutboats @sfackler

@jonhoo jonhoo mentioned this pull request Aug 10, 2020
Closed
@jonhoo
Copy link
Contributor Author

jonhoo commented Aug 21, 2020

Another ping for checkboxes @SimonSapin @withoutboats @sfackler — I'd love to see this land in time for the next release window on the 27th!

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 21, 2020
@rfcbot
Copy link

rfcbot commented Aug 21, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@Dylan-DPC-zz Dylan-DPC-zz modified the milestones: 1.47, 1.48 Aug 24, 2020
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 31, 2020
@rfcbot
Copy link

rfcbot commented Aug 31, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@jonhoo
Copy link
Contributor Author

jonhoo commented Sep 1, 2020

@Amanieu done! Also merged master for good measure.

@dtolnay
Copy link
Member

dtolnay commented Sep 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2020

📌 Commit 8b55360 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2020
@bors
Copy link
Contributor

bors commented Sep 1, 2020

⌛ Testing commit 8b55360 with merge eb9e7c3...

@bors
Copy link
Contributor

bors commented Sep 1, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: dtolnay
Pushing eb9e7c3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2020
@bors bors merged commit eb9e7c3 into rust-lang:master Sep 1, 2020
@jonhoo jonhoo deleted the stabilize-vecdeque-make_contiguous branch September 1, 2020 21:41
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Sep 2, 2020
@dtolnay dtolnay self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu

@Mark-Simulacrum Mark-Simulacrum

@dtolnay dtolnay

Assignees

@Amanieu Amanieu

@dtolnay dtolnay

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for fn VecDeque::make_contiguous