Skip to content

bootstrap: Print units for "finished in xxx" message #78087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

bootstrap: Print units for "finished in xxx" message #78087

merged 1 commit into from
Oct 19, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Oct 18, 2020

It now says "finished in xxx seconds".

Also slightly improved some wording in the README.

@camelid
bootstrap: Print units for "finished in xxx" message
6716c83 
It now says "finished in xxx seconds".

Also slightly improved some wording in the README.
@camelid camelid added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Oct 18, 2020
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 19, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 19, 2020

📌 Commit 6716c83 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 19, 2020

@bors rollup

@bors
Copy link
Collaborator

bors commented Oct 19, 2020

⌛ Testing commit 6716c83 with merge cb2462c...

@bors
Copy link
Collaborator

bors commented Oct 19, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing cb2462c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2020
@bors bors merged commit cb2462c into rust-lang:master Oct 19, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 19, 2020
@camelid camelid deleted the bootstrap-print-units branch October 19, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
6 participants
@camelid @rust-highfive @jyn514 @bors @Mark-Simulacrum @rustbot