Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #81113

Merged
merged 30 commits into from
Jan 17, 2021
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
b498870
use hir::Place instead of Symbol in closure_kind_origin
roxelo Dec 3, 2020
b7071b2
resolve: Simplify collection of traits in scope
petrochenkov Jan 6, 2021
7aca2fa
Remove is_dllimport_foreign_item def from cg_ssa
bjorn3 Jan 13, 2021
6766070
Allow downloading LLVM on Windows
jyn514 Jan 12, 2021
5c4adbe
Add all tier 1 platforms to supported platforms for "if-available"
jyn514 Jan 13, 2021
8b702e0
Support non-stage0 check
Mark-Simulacrum Jan 16, 2021
c17ed34
Print which stage is being checked (now that it may not be stage0)
jyn514 Jan 16, 2021
53989e4
Allow configuring the default stage for `x.py check`
jyn514 Jan 16, 2021
50ee0b2
BTreeMap: clean up a few more comments
ssomers Nov 18, 2020
15f0921
correctly deal with late-bound lifetimes in anon consts
lcnr Nov 22, 2020
76003f3
Use Option::map instead of open-coding it
LingMan Dec 30, 2020
5a706cf
Use Option::unwrap_or instead of open-coding it
LingMan Jan 16, 2021
7f9a2cf
resolve: Reject ambiguity built-in attr vs different built-in attr
petrochenkov Dec 13, 2020
4e27ed3
Add benchmark and fast path for BufReader::read_exact
saethlin Dec 19, 2020
3e16e92
Add NonZeroUn::is_power_of_two
scottmcm Jan 17, 2021
f07dd6d
Remove dead code
rylev Dec 18, 2020
c127ed6
Force vec! to expressions only
bugadani Jan 16, 2021
f783871
Rollup merge of #79298 - lcnr:new-elysium, r=matthewjasper
m-ou-se Jan 17, 2021
3d5e7e0
Rollup merge of #80031 - petrochenkov:builtina, r=estebank
m-ou-se Jan 17, 2021
152f425
Rollup merge of #80201 - saethlin:bufreader-read-exact, r=KodrAus
m-ou-se Jan 17, 2021
19f9780
Rollup merge of #80635 - sexxi-goose:use-place-instead-of-symbol, r=n…
m-ou-se Jan 17, 2021
ffcbeef
Rollup merge of #80765 - petrochenkov:traitsinscope, r=matthewjasper
m-ou-se Jan 17, 2021
cfe2253
Rollup merge of #80932 - jyn514:download-windows-llvm, r=Mark-Simulacrum
m-ou-se Jan 17, 2021
8f2ee87
Rollup merge of #80983 - bjorn3:no_dup_is_dllimport_foreign_item, r=n…
m-ou-se Jan 17, 2021
92dbfb5
Rollup merge of #81064 - Mark-Simulacrum:support-stage1-check, r=jyn514
m-ou-se Jan 17, 2021
19370a4
Rollup merge of #81080 - bugadani:vec-diag, r=oli-obk,m-ou-se
m-ou-se Jan 17, 2021
366f97b
Rollup merge of #81082 - ssomers:btree_cleanup_comments, r=Mark-Simul…
m-ou-se Jan 17, 2021
34e073f
Rollup merge of #81084 - LingMan:map, r=oli-obk
m-ou-se Jan 17, 2021
7e2425a
Rollup merge of #81095 - LingMan:unwrap, r=oli-obk
m-ou-se Jan 17, 2021
8016846
Rollup merge of #81107 - scottmcm:nonzero-is_power_of_two, r=kennytm
m-ou-se Jan 17, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add NonZeroUn::is_power_of_two
This saves instructions on both new and old machines.
  • Loading branch information
scottmcm committed Jan 17, 2021
commit 3e16e9211ef7eff4d421f384140e729df1120372
40 changes: 40 additions & 0 deletions library/core/src/num/nonzero.rs
Original file line number Diff line number Diff line change
@@ -286,3 +286,43 @@ nonzero_integers_div! {
NonZeroU128(u128);
NonZeroUsize(usize);
}

macro_rules! nonzero_unsigned_is_power_of_two {
( $( $Ty: ident )+ ) => {
$(
impl $Ty {

/// Returns `true` if and only if `self == (1 << k)` for some `k`.
///
/// On many architectures, this function can perform better than `is_power_of_two()`
/// on the underlying integer type, as special handling of zero can be avoided.
///
/// # Examples
///
/// Basic usage:
///
/// ```
/// #![feature(nonzero_is_power_of_two)]
///
#[doc = concat!("let eight = std::num::", stringify!($Ty), "::new(8).unwrap();")]
/// assert!(eight.is_power_of_two());
#[doc = concat!("let ten = std::num::", stringify!($Ty), "::new(10).unwrap();")]
/// assert!(!ten.is_power_of_two());
/// ```
#[unstable(feature = "nonzero_is_power_of_two", issue = "81106")]
#[inline]
pub const fn is_power_of_two(self) -> bool {
// LLVM 11 normalizes `unchecked_sub(x, 1) & x == 0` to the implementation seen here.
// On the basic x86-64 target, this saves 3 instructions for the zero check.
// On x86_64 with BMI1, being nonzero lets it codegen to `BLSR`, which saves an instruction
// compared to the `POPCNT` implementation on the underlying integer type.

intrinsics::ctpop(self.get()) < 2
}

}
)+
}
}

nonzero_unsigned_is_power_of_two! { NonZeroU8 NonZeroU16 NonZeroU32 NonZeroU64 NonZeroU128 NonZeroUsize }