Skip to content

Suggest accessing field when appropriate #81504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 1, 2021
+185 −0
Merged

Suggest accessing field when appropriate #81504

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9e4ed33
Suggest accessing field when code compiles with it
hkmatsumoto Jan 28, 2021
a9abf6f
Add test for match expression
hkmatsumoto Jan 29, 2021
f641f51
Add rust-fix test
hkmatsumoto Jan 29, 2021
ad9f707
Fix test to check help message as well
hkmatsumoto Jan 30, 2021
08d31e0
Remove logging iterator
hkmatsumoto Jan 30, 2021
2ce2d14
Account for union
hkmatsumoto Jan 30, 2021
6bc9634
Rename function to `suggest_accessing_field_where_appropriate`
hkmatsumoto Jan 30, 2021
a292ac7
Fix prefix of debug log
hkmatsumoto Jan 31, 2021
f45a993
Rustfmt
hkmatsumoto Jan 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove logging iterator
@hkmatsumoto
hkmatsumoto committed Jan 30, 2021
commit 08d31e0f09f79a41e0cfc26247d41fea1489adf9
3 changes: 0 additions & 3 deletions compiler/rustc_infer/src/infer/error_reporting/mod.rs
View file
Original file line number Diff line number Diff line change
@@ -1838,9 +1838,6 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
.iter()
.filter(|field| field.vis.is_accessible_from(field.did, self.tcx))
.map(|field| (field.ident.name, field.ty(self.tcx, expected_substs)))
.inspect(|(name, ty)| {
debug!("suggest_field_where_appropriate: name={:?}, ty={:?}", name, ty)
})
.find(|(_, ty)| ty::TyS::same_type(ty, exp_found.found))
{
if let ObligationCauseCode::Pattern { span: Some(span), .. } = cause.code {