Turn may_have_side_effect into an associated constant #82043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit cdf4aeedf8e17f135d5eb47c93216494e697b76a with merge 24e0ffc40ec8010079c7918ebf7977e9df4b06b0... |
|
☀️ Try build successful - checks-actions |
|
Queued 24e0ffc40ec8010079c7918ebf7977e9df4b06b0 with parent 3f5aee2, future comparison URL. |
|
Finished benchmarking try commit (24e0ffc40ec8010079c7918ebf7977e9df4b06b0): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
The `may_have_side_effect` is an implementation detail of `TrustedRandomAccess` trait. It describes if obtaining an iterator element may have side effects. It is currently implemented as an associated function. Turn `may_have_side_effect` into an associated constant. This makes the value immediately available to the optimizer.
tmiasko
force-pushed
the
may-have-side-effect
branch
from
cdf4aee to
dc3304c
Compare
|
seems no much change in the compiler's instruction count on average? |
|
@kennytm do you need some further input or motivation behind those changes? The current implementation relies on inter procedural optimizations to determine that Implementing this as an associated constant avoids such problems altogether. The future of |
|
@tmiasko Looks fine to me but since you invoked perf i'm just awaiting for analysis if this matches your expectation 😅. |
|
I didn't expect any significant impact on perf benchmarks. The perf run was just in case something unanticipated happened like with |
|
okay. @bors r+ |
|
📌 Commit dc3304c has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit dc3304c with merge 14de747478bb9ca170736a138a1adb94b00ad328... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
may_have_side_effectis an implementation detail ofTrustedRandomAccesstrait. It describes if obtaining an iterator element may have side effects. It
is currently implemented as an associated function.
Turn
may_have_side_effectinto an associated constant. This makes thevalue immediately available to the optimizer.