-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Remove most fields from ExternalCrate #84457
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 6c6bd88 with merge 336b6b63c7dd2281785650fb6ce1c4066cffe416... |
☀️ Try build successful - checks-actions |
Queued 336b6b63c7dd2281785650fb6ce1c4066cffe416 with parent 5f1aeb5, future comparison URL. |
Finished benchmarking try commit (336b6b63c7dd2281785650fb6ce1c4066cffe416): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Interesting - max RSS looks like noise, but up to -3.8% on instruction count. |
Thanks! @bors: r+ |
📌 Commit 6c6bd88 has been approved by |
⌛ Testing commit 6c6bd88 with merge 38abe86bb3b0144123be65349c2afb1a94eb3ed4... |
💔 Test failed - checks-actions |
dist-x86_64-apple-alt failed without logs :/ @bors retry |
☀️ Test successful - checks-actions |
Once #84304 is fixed, I can get rid of ExternCrate altogether in favor of CrateNum, but in the meantime, this shrinks ExternalCrate quite a lot.
This might hurt compile-times; if it does, I can add
primitive
andkeyword
queries. I expect this to improve compilemem.Helps with #76382.
r? GuillaumeGomez