unix: Use metadata for DirEntry::file_type fallback
#93471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `DirEntry::file_type` fails to match a known `d_type`, we should fall back to `DirEntry::metadata` instead of a bare `lstat`, because this is faster and more reliable on targets with `fstatat`.
|
LGTM. Looking through the tests it seems like we're lacking one that checks that direntry.metadata() gets the symlink metadata, but that's a preexisting issue. @bors r+ rollup |
|
📌 Commit d70b9c0 has been approved by |
bors
added
the
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 30, 2022
…the8472 unix: Use metadata for `DirEntry::file_type` fallback When `DirEntry::file_type` fails to match a known `d_type`, we should fall back to `DirEntry::metadata` instead of a bare `lstat`, because this is faster and more reliable on targets with `fstatat`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#93395 (Improve suggestion for escaping reserved keywords) - rust-lang#93403 (review the total_cmp documentation) - rust-lang#93461 (Accommodate yield points in the format_args expansion) - rust-lang#93462 (Document `SystemTime` platform precision) - rust-lang#93471 (unix: Use metadata for `DirEntry::file_type` fallback) - rust-lang#93480 (Remove deprecated and unstable slice_partition_at_index functions) - rust-lang#93485 (core: Remove some redundant {}s from the sorting code) - rust-lang#93494 (kmc-solid: Inherit the calling task's base priority in `Thread::new`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DirEntry::file_typefails to match a knownd_type, we shouldfall back to
DirEntry::metadatainstead of a barelstat, becausethis is faster and more reliable on targets with
fstatat.