Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HashMap not displaying correctly in VS debugger #93626

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix HashMap not displaying correctly in VS debugger #93626

merged 1 commit into from
Feb 8, 2022
+1 −1

Conversation

wesleywiser
Copy link
Member

The natvis to render HashMaps was not working correctly in Visual Studio
because the type names for tuples changed from tuple$<A, B> to
tuple$<A,B> (notice the missing space). WinDbg and cdb continued to
parse this type name which is why no tests in CI broke. VS however is
slightly more strict and this caused the visualizer to break.

Since we cannot test the VS debugger in CI, I'm not checking in any
test changes.

Fixes #92286

r? @michaelwoerister

@wesleywiser
Fix HashMap not displaying correctly in VS debugger
fa99aaa 
The natvis to render HashMaps was not working correctly in Visual Studio
because the type names for tuples changed from `tuple$<A, B>` to
`tuple$<A,B>` (notice the missing space). WinDbg and cdb continued to
parse this type name which is why no tests in CI broke. VS however is
slightly more strict and this caused the visualizer to break.

Since we cannot test the VS debugger in CI, I'm not checking in any
test changes.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2022
@wesleywiser wesleywiser added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) O-windows-msvc Toolchain: MSVC, Operating system: Windows labels Feb 3, 2022
@michaelwoerister
Copy link
Member

WinDbg and cdb continued to parse this type name which is why no tests in CI broke. VS however is slightly more strict and this caused the visualizer to break.

Yuck! 😄

Thanks for the PR, @wesleywiser!

@bors r+ rollup=never (excluding from rollups because debuginfo test)

@bors
Copy link
Contributor

bors commented Feb 4, 2022

📌 Commit fa99aaa has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2022
@bors
Copy link
Contributor

bors commented Feb 6, 2022

⌛ Testing commit fa99aaa with merge ff3d374e48bbe8270a77959efed26c50c332a808...

@bors
Copy link
Contributor

bors commented Feb 6, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 6, 2022
@matthiaskrgr
Copy link
Member

@bors retry probably #93329 again (msvc-1 hang, logs not visible yet)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Feb 7, 2022

⌛ Testing commit fa99aaa with merge c508b9ada4a130b90672443889efa1729b0b3858...

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Feb 7, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2022
@wesleywiser
Copy link
Member Author 

error: failed to download from `[https://crates.io/api/v1/crates/pretty_assertions/0.6.1/download`](https://crates.io/api/v1/crates/pretty_assertions/0.6.1/download%60)

Caused by:
  [28] Timeout was reached (failed to download any data for `pretty_assertions v0.6.1` within 30s)

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2022
@bors
Copy link
Contributor

bors commented Feb 7, 2022

⌛ Testing commit fa99aaa with merge 57c857a05be590bdd03c43d1d799b923892937b0...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......... (50/59)
........  (59/59)


/checkout/src/test/rustdoc-gui/search-result-display.goml search-result-display... FAILED
[ERROR] (line 6) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:44

@bors
Copy link
Contributor

bors commented Feb 7, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2022
@wesleywiser
Copy link
Member Author

@bors retry

Rustdoc gui test failure

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2022
@bors
Copy link
Contributor

bors commented Feb 8, 2022

⌛ Testing commit fa99aaa with merge ca6439d520e13b93559960f5762a172a2a338784...

@rust-log-analyzer
Copy link
Collaborator

The job i686-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Feb 8, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2022
@ehuss
Copy link
Contributor

ehuss commented Feb 8, 2022

@bors retry

---- [ui] ui/threads-sendsync/tcp-stress.rs stdout ----

error: test run failed!
status: exit status: 1
command: "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/threads-sendsync/tcp-stress/a"

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2022
@bors
Copy link
Contributor

bors commented Feb 8, 2022

⌛ Testing commit fa99aaa with merge 775e480...

@bors
Copy link
Contributor

bors commented Feb 8, 2022

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 775e480 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 8, 2022
@bors bors merged commit 775e480 into rust-lang:master Feb 8, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 8, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (775e480): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@ehuss ehuss mentioned this pull request Feb 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) merged-by-bors This PR was explicitly merged by bors. O-windows-msvc Toolchain: MSVC, Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.

HashMap not rendered properly when using MSVC debugger
9 participants
@wesleywiser @michaelwoerister @bors @matthiaskrgr @rust-log-analyzer @ehuss @rust-timer @rust-highfive @rustbot