Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip a test if symlink creation is not possible #95114

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

ChrisDenton
Copy link
Member

If someone running tests on Windows does not have Developer Mode enabled then creating symlinks will fail which in turn would cause this test to fail. This can be a stumbling block for contributors.

@rust-highfive
Copy link
Collaborator

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2022
@the8472 the8472 added T-libs Relevant to the library team, which will review and decide on the PR/issue. O-windows Operating system: Windows labels Mar 20, 2022
@the8472
Copy link
Member

the8472 commented Mar 20, 2022

With #93283 there's a precedent to skip a test locally but keep it mandatory in CI, so this should be fine.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 20, 2022

📌 Commit 68c03cd has been approved by the8472

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2022
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#95114 (Skip a test if symlink creation is not possible)
 - rust-lang#95131 (Fix docs for default rmeta filename.)
 - rust-lang#95135 (Fix a not emitted unmatched angle bracket error)
 - rust-lang#95145 (Fix typo interator->iterator)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3c02b51 into rust-lang:master Mar 21, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 21, 2022
@bors
Copy link
Contributor

bors commented Mar 21, 2022

⌛ Testing commit 68c03cd with merge 51558cc...

@ChrisDenton ChrisDenton deleted the symlink-test branch March 21, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants