Implement apply_switch_int_edge_effects for backward analyses
#95120
+153
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
ecstatic-morse
suggested changes
Mar 24, 2022
There was a problem hiding this comment.
Implementation looks good for the most part. Left a few comments. When there's a pass that actually uses this it would be good to add a peek test to ensure that it computes the correct results.
* Add lazily computed `switch_sources` data structure * Don't assume a target has only one associated value
smoelius
force-pushed
the
backward-switch-int
branch
from
848a49b to
37ebd47
Compare
smoelius
changed the title
apply_switch_int_edge_effect for backward analysesapply_switch_int_edge_effects for backward analyses
|
@ecstatic-morse I think 37ebd47 addresses your comments and the bug that I found. |
ecstatic-morse
approved these changes
Mar 27, 2022
|
LGTM. Hopefully this is useful to you. Now that we have 3 different cached computations on MIR bodies with the same implementation, we probably want some sort of generalized framework. |
|
@bors r+ |
|
📌 Commit 241ec5b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#94939 (diagnostics: suggest missing comma in bad FRU syntax) - rust-lang#95120 (Implement `apply_switch_int_edge_effects` for backward analyses) - rust-lang#95364 (Add long error explanation for E0667) - rust-lang#95366 (Remove test files with duplicated checksums) - rust-lang#95368 (Fix typo in `String::try_reserve_exact` docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #94576 for some discussion.
r? @ecstatic-morse