Rollup of 5 pull requests #95250
Rollup of 5 pull requests #95250
Conversation
… r=davidtwco Better errors when a Copy impl on a Struct is not self-consistent As discovered in a Zulip thread with `@nnethercote` and `@Mark-Simulacrum,` it's not immediately obvious why a field on an ADT doesn't implement `Copy`. This PR attempts to give slightly more detailed information by spinning up a fulfillment context to try to dig down and discover transitive fulfillment errors that cause `is_copy_modulo_regions` to fail on a ADT field. The error message still kinda sucks, but should only show up in the case that an existing error message was totally missing... so I think it's a good compromise for now?
… r=oli-obk Fix auto traits in rustdoc Fixes rust-lang#90324. cc `@matthewjasper` r? `@Aaron1011`
…-obk interpret/memory: simplify check_and_deref_ptr *Finally* I saw a way to make this code simpler. The odd preprocessing in `let ptr_or_addr =` has bothered me since forever, but it actually became unnecessary in the last provenance refactoring. :) This also leads to slightly more explicit error messages as a nice side-effect. 🎉 r? `@oli-obk`
…or-ty, r=oli-obk remove `[async output]` from `impl Future` pretty-printing self-explanatory, guess it's not as helpful as I thought when I added it 4 months ago re rust-lang#95089 (comment)
…uct-enum-with-underscore, r=estebank Stop emitting E0026 for struct enums with underscores This patch resolves a part of rust-lang#83263; r? `@estebank`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit fab7a6a has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Tested on commit rust-lang/rust@37b55c8. Direct link to PR: <rust-lang/rust#95250> 💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb). 💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb).
|
Finished benchmarking commit (37b55c8): comparison url. Summary: This benchmark run shows 30 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
|
@rustbot label: +perf-regression-triaged The regression is only in rustdoc, and @GuillaumeGomez is alright with permitting this regression in order to fix a bug for now. I believe I know how to get rid of the perf regression while keeping the bug fixed, but it is a larger refactoring that I am coordinating with @GuillaumeGomez on |
Successful merges:
[async output]fromimpl Futurepretty-printing #95225 (remove[async output]fromimpl Futurepretty-printing)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup