Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #95667

Merged
merged 34 commits into from
Apr 5, 2022
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
76756cc
bootstrap.py: nixos check in /etc/os-release with quotes
ben0x539 Mar 23, 2022
064a559
Fix `x doc --stage 0 compiler`
jyn514 Mar 29, 2022
bf2c3b0
Fix ICE in rustdoc intra doc links when trying to get traits in scope…
GuillaumeGomez Apr 4, 2022
50cc0fa
Add test to ensure rustdoc does not panic on intra doc link pass
GuillaumeGomez Apr 4, 2022
a8877cf
Handle reporting invariance of fn pointer
compiler-errors Apr 2, 2022
2a129d4
Format invariance notes with backticks
compiler-errors Apr 2, 2022
8c68456
errors: introduce `DiagnosticMessage`
davidtwco Mar 23, 2022
c45f295
span: move `MultiSpan`
davidtwco Mar 24, 2022
7f91697
errors: implement fallback diagnostic translation
davidtwco Mar 26, 2022
d5119c5
errors: implement sysroot/testing bundle loading
davidtwco Mar 28, 2022
2bf64d6
macros: update comments
davidtwco Mar 30, 2022
8677fef
macros: move suggestion type handling to fn
davidtwco Mar 30, 2022
9956d4f
macros: add args for non-subdiagnostic fields
davidtwco Mar 30, 2022
a52b507
errors: disable directionality isolation markers
davidtwco Mar 31, 2022
f0de7df
macros: update session diagnostic errors
davidtwco Mar 30, 2022
d0fd8d7
macros: translatable struct attrs and warnings
davidtwco Mar 31, 2022
8100541
macros: rename `#[message]` to `#[primary_span]`
davidtwco Mar 31, 2022
70ee0c9
macros: add `#[no_arg]` to skip `set_arg` call
davidtwco Mar 31, 2022
72dec56
macros: optional error codes
davidtwco Mar 31, 2022
a88717c
macros: support translatable labels
davidtwco Mar 31, 2022
b40ee88
macros: note/help in `SessionDiagnostic` derive
davidtwco Mar 31, 2022
22685b9
macros: support translatable suggestions
davidtwco Mar 31, 2022
141f840
errors: don't try load default locale from sysroot
davidtwco Apr 2, 2022
c6a3349
typeck: remove now-unnecessary parameter from diag
davidtwco Apr 2, 2022
e27389b
errors: add links to fluent documentation
davidtwco Apr 2, 2022
3c2f864
session: opt for enabling directionality markers
davidtwco Apr 3, 2022
66f22e5
errors: use `impl Into<FluentId>`
davidtwco Apr 3, 2022
da56d92
tidy: add fluent dependencies to whitelist
davidtwco Apr 3, 2022
ccd4820
errors: support fluent + parallel compiler
davidtwco Apr 3, 2022
b7047c2
Rollup merge of #95234 - ben0x539:nixquotes, r=Dylan-DPC
Dylan-DPC Apr 5, 2022
73eab35
Rollup merge of #95449 - jyn514:doc-stage-0, r=ehuss
Dylan-DPC Apr 5, 2022
d473024
Rollup merge of #95512 - davidtwco:diagnostic-translation, r=oli-obk
Dylan-DPC Apr 5, 2022
2a7e7bd
Rollup merge of #95607 - compiler-errors:issue-95272, r=Aaron1011
Dylan-DPC Apr 5, 2022
bf44a87
Rollup merge of #95645 - GuillaumeGomez:intra-doc-link-ice-traits-in-…
Dylan-DPC Apr 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typeck: remove now-unnecessary parameter from diag
Removes `expected_pluralize` parameter from diagnostic struct which is
no longer necessary as the Fluent message can determine the correct
pluralization.

Signed-off-by: David Wood <[email protected]>
davidtwco committed Apr 5, 2022
commit c6a3349bd737a211f9adbfc161ff89a9b66f97ef
3 changes: 1 addition & 2 deletions compiler/rustc_typeck/src/check/intrinsic.rs
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ use crate::errors::{
};
use crate::require_same_types;

use rustc_errors::{pluralize, struct_span_err};
use rustc_errors::struct_span_err;
use rustc_hir as hir;
use rustc_middle::traits::{ObligationCause, ObligationCauseCode};
use rustc_middle::ty::subst::Subst;
@@ -43,7 +43,6 @@ fn equate_intrinsic_type<'tcx>(
span,
found,
expected,
expected_pluralize: pluralize!(expected),
descr,
});
false
1 change: 0 additions & 1 deletion compiler/rustc_typeck/src/errors.rs
Original file line number Diff line number Diff line change
@@ -30,7 +30,6 @@ pub struct WrongNumberOfGenericArgumentsToIntrinsic<'a> {
pub span: Span,
pub found: usize,
pub expected: usize,
pub expected_pluralize: &'a str,
pub descr: &'a str,
}