Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create guide to ICE-breaker groups and specifically advice for LLVM #452

Merged
merged 1 commit into from
Oct 2, 2019
Merged

create guide to ICE-breaker groups and specifically advice for LLVM #452

merged 1 commit into from
Oct 2, 2019

Conversation

nikomatsakis
Copy link
Contributor

@spastorino spastorino mentioned this pull request Sep 20, 2019
Closed
10 tasks
spastorino
spastorino reviewed Sep 21, 2019
View reviewed changes
Copy link
Member

@spastorino spastorino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just left a couple of minor comments.
Seems good to merge for now because it clearly explains that there are things that we are currently figuring out.

@nikomatsakis nikomatsakis merged commit b71b2a5 into rust-lang:master Oct 2, 2019
mark-i-m pushed a commit to spastorino/rustc-dev-guide that referenced this pull request Jan 2, 2020
@nikomatsakis @mark-i-m
create guide to ICE-breaker groups and specifically advice for LLVM (r…
e082353 
…ust-lang#452)
@nikomatsakis nikomatsakis mentioned this pull request Jan 9, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spastorino spastorino spastorino left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikomatsakis @spastorino