Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give overview of MIR dataflow framework #583

Merged
merged 4 commits into from
Sep 13, 2020

Conversation

ecstatic-morse
Copy link
Contributor

Resolves #564.

I'm a few PRs away from transitioning all existing dataflow analyses in the compiler to the new framework, which can handle gen-kill problems as well as more general ones. When this is finished, we'll want to have an overview of the new framework in the guide.

This is a rough draft, and most of the links don't work since the module structure will change when the old framework is removed. For now, it exists mostly to prove that I've not forgotten about doing this 😄.

@ecstatic-morse
Copy link
Contributor Author

I will work on this after some form of rust-lang/rust#71006 lands, since that PR requires changing a lot of the terminology used by the dataflow framework, both in the public API and the implementation.

@JohnTitor JohnTitor added the S-blocked Status: this PR is blocked waiting for something label Apr 17, 2020
@tshepang tshepang removed the S-blocked Status: this PR is blocked waiting for something label May 10, 2020
@mark-i-m
Copy link
Member

mark-i-m commented Jun 5, 2020

Ping @ecstatic-morse is there a different PR blocking this now?

@ecstatic-morse
Copy link
Contributor Author

Just blocked on me finding the time, unfortunately.

@mark-i-m
Copy link
Member

mark-i-m commented Aug 2, 2020

Friendly ping @ecstatic-morse :) I know you're busy -- just wanted to make sure this is still on your radar.

@jyn514 jyn514 added the S-waiting-on-author Status: this PR is waiting for additional action by the OP label Sep 8, 2020
@ecstatic-morse ecstatic-morse changed the title [WIP] Give overview of MIR dataflow framework Give overview of MIR dataflow framework Sep 13, 2020
@ecstatic-morse
Copy link
Contributor Author

This is not as complete as I would like it to be, but it's much better than nothing and has been updated to include the "arbitrary lattice" extension to the dataflow framework.

Sorry I didn't complete this in time for @mark-i-m to review it, although I would still welcome their feedback. Maybe @JohnTitor or @jyn514 could take a look?

@ecstatic-morse ecstatic-morse added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Sep 13, 2020
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@ecstatic-morse
Copy link
Contributor Author

Fixed the broken link and did some line-editing for clarity. Should be good to go now.

@jyn514
Copy link
Member

jyn514 commented Sep 13, 2020

Sounds good to me, further improvements can go in follow-ups :)

Thanks so much for writing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document MIR dataflow framework
5 participants