Fix link/wording for parse_nt
#819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-i-m
approved these changes
Aug 3, 2020
src/overview.md
Outdated
| @@ -42,7 +42,7 @@ we'll talk about that later. | |||
| analysis. The crate entry points for the parser are the `Parser.parse_crate_mod()` and | |||
| `Parser.parse_mod()` methods found in `librustc_parse::parser::item`. The external | |||
| module parsing entry point is `librustc_expand::module::parse_external_mod`. And | |||
| the macro parser entry point is `rustc_expand::mbe::macro_parser::parse_nt`. | |||
| the macro parser entry point is [`Parser.parse_nonterminal()`][parse_nonterminal]. | |||
There was a problem hiding this comment.
Suggested change
| the macro parser entry point is [`Parser.parse_nonterminal()`][parse_nonterminal]. | |
| the macro parser entry point is [`Parser::parse_nonterminal()`][parse_nonterminal]. |
There was a problem hiding this comment.
I use . because we have Parser.parse_crate_mod() above. Should we replace them too?
There was a problem hiding this comment.
Oh, I didn't notice that. Yeah, would you mind changing the other ones to :: too?
There was a problem hiding this comment.
Sure! Addressed via bbb27ac.
mark-i-m
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of rust-lang/rust#74826