Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link for BoundRegion #998

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Dec 30, 2020

"name" -- the [`BoundRegion`] struct. This struct can contain a
"name" -- the [`BoundRegionKind`] enum. This enum can contain a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that we should still be linking to BoundRegion – it's just a struct now, rather than an enum.

Copy link
Member Author

@JohnTitor JohnTitor Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more straightforward to use BoundRegionKind like ExprKind or similar, since we use Kind thing mainly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that BoundRegion is only a wrapper around BoundRegionKind, and that we talk about what kind of name it can be in this paragraph, I think linking to BoundRegionKind makes more sense

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future BoundRegion may have more fields than just kind, so wouldn't we want to link people to that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I was too late 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that if this is the case this chapter will need updating anyway

"name" -- the [`BoundRegion`] struct. This struct can contain a
"name" -- the [`BoundRegionKind`] enum. This enum can contain a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that BoundRegion is only a wrapper around BoundRegionKind, and that we talk about what kind of name it can be in this paragraph, I think linking to BoundRegionKind makes more sense

@LeSeulArtichaut LeSeulArtichaut merged commit 148742b into rust-lang:master Dec 31, 2020
@JohnTitor JohnTitor deleted the bound-region-link branch December 31, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants