Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for large amount of extern functions #789

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

rylev
Copy link
Member

@rylev rylev commented Oct 29, 2020

This is a benchmark which tracks the effectiveness of the change in rust-lang/rust#78448. On my machine, the current nightly compiler builds benchmark crate in 2.5 seconds. The unoptimized build of rust-lang/rust#78448 builds the crate in 1.1 seconds.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I don't know if there are any special considerations when adding new benchmarks.

@Mark-Simulacrum Mark-Simulacrum merged commit 53cbb4c into rust-lang:master Nov 2, 2020
@rylev rylev deleted the externs branch November 2, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants