fix not to overwrite on other platforms #3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
approved these changes
Dec 20, 2019
| } else { | ||
| let should_insert = !mods_outside_ast | ||
| .iter() | ||
| .any(|(outside_path, _, _)| outside_path == &path); |
There was a problem hiding this comment.
Nit: sorry for being picky, but I would rather write this using all instead of negation + any:
let should_insert = mods_outside_ast
.iter()
.all(|(outside_path, _, _)| outside_path != &path);
|
Hi, does cargo-fmt 1.4.11 integrate this patch ? I encounter a bug very similar to #3956 |
|
#4100 implements a similar fix, and I can't reproduce the error on the latest master |
|
@calebcartwright do you want me to backport the tests to prevent a regression? |
Sure, that'd be great! |
|
Will get on that soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3956