Fix for handling empty code block in doc comments #4902
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for issue #4793 for handling empty code block in doc comments (replacing PR #4895). If the doc comments code block includes only empty lines than the output is one line with empty code (
///
). If no code line was included between the two///'''
then the output also does not include any code line.A simpler solution could be to add
trim()
here, i.e to make it_ if self.code_block_buffer.trim().is_empty() =>...
. however it seem that changingformat_code_block()
is more robust.