test idempotence of trim_me
in strings3.rs
#2215
Open
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, this change doesn't directly test for idempotence, as the
fn
is called once instead of being chained. I still believe it adds value, because it can make the challenge "harder" while still being fair.Note
The following is just feedback from my recent experience. It can be ignored as "off-topic", but I believe it might be helpful for designing exercises in general.
BTW, when I was solving it, I felt like using
trim
method was "cheating", so I implemented it myself:Originally, the code was this:
Aside from being an eyesore, it doesn't work for
""
(input.len() - 1
is always an invalid index). That's why I added some extra tests locally, as a "challenge" to myself.Should I add the empty
str
test?