-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
rust: add caveats #218316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: add caveats #218316
Conversation
(I believe there's nothing wrong with my addition; it's just that the |
Now that #218030 has been merged, I'll sync this real quick... |
@bevanjkay Thanks for the prompt triage! Is there anything else I can do to help this PR getting merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better to me, thanks @rami3l!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Still needs a bit of work here.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Hello, it's me again on behalf of the rustup team here!
We have noticed a common issue with a regular
brew
user developing with Rust:rustup
installation (either installed with or withoutbrew
).brew install rust
(usually implicitly as a build dependency), the binaries provided by that package will shadow existingrustup
-provided binaries.rustup
-installed toolchains/components might seem "gone", causing subtle breakages that are essentially out of our control.We already have warnings when
brew install rust
happens beforerustup
is installed, but unfortunately checking the existence of abrew
-managed Rust installation will be much more costly afterwards, so I'm making this PR hoping to further inform potential users of this conflict in the "after" case.Hopefully closes rust-lang/rustup#1236.