Skip to content

docs(user-guide): cover correct $PATH configuration for proxies #4283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Apr 9, 2025

As a prerequisite of merging my Homebrew/homebrew-core#218316 (and thus addressing #1236 (comment)), this addition has been suggested by @MikeMcQuaid (the current lead of homebrew) in Homebrew/homebrew-core#218316 (comment):

the actual instructions should be in the rustup formula and/or the official Rust documentation (and provide a link to there instead).

As-is the existing text is:

  • far too long (the longer the text, the less likely any of it is to be read)
  • unclear on what should be added where; there's no specifics

@rami3l rami3l requested review from djc and ChrisDenton April 9, 2025 14:33
@rami3l rami3l force-pushed the docs/coexist-with-system branch from cb1ec60 to 269fc34 Compare April 9, 2025 14:43
Copy link

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One suggestion of how you could potentially make it easier to debug this.

@rami3l rami3l force-pushed the docs/coexist-with-system branch from 269fc34 to a9f9cdb Compare April 9, 2025 16:28
@rami3l rami3l requested a review from ChrisDenton April 9, 2025 16:28
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear to me, thanks!

@rami3l rami3l added this pull request to the merge queue Apr 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025
@rami3l rami3l added this pull request to the merge queue Apr 10, 2025
Merged via the queue into master with commit 3dc390d Apr 10, 2025
29 checks passed
@rami3l rami3l deleted the docs/coexist-with-system branch April 10, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants