Change default for RUSTUP_WINDOWS_PATH_ADD_BIN #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
approved these changes
Mar 12, 2024
djc
approved these changes
Mar 12, 2024
ehuss
force-pushed
the
change-windows-bin-path-default
branch
from
8dc8a39 to
a34d06a
Compare
3 tasks
|
Just raising that this seems to have broken |
|
As an additional data point, Dylint is currently using It may be that we could set |
|
Can one of you open a new issue discussing what the use case here is and how/why we broke it? |
This was referenced May 16, 2024
This was referenced Feb 24, 2025
DaAlbrecht
pushed a commit
to TheBevyFlock/bevy_cli
that referenced
this pull request
Feb 24, 2025
Fixes #267! For more context, see [this comment](#267 (comment)): > I found the issue! Due to [rust-lang/rustup#3703](rust-lang/rustup#3703), Rustup no longer modifies the `PATH` on Windows because it prevented sub-invocations of `cargo` and `rustc` from going through their proxy. There was a [call for testing](https://internals.rust-lang.org/t/help-test-windows-behavior-between-rustup-and-cargo/20237) related to this, but it was announced before the linter was ever created. Because I don't use Windows frequently, I never caught the issue. > > We can fix this by setting `RUSTUP_WINDOWS_PATH_ADD_BIN=1`: > > ```cmd > > set RUSTUP_WINDOWS_PATH_ADD_BIN=1 > > rustup run nightly-2025-01-09 .\bevy_lint.exe > ```
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default for the RUSTUP_WINDOWS_PATH_ADD_BIN opt-in to fix the issue where adding the
bindirectory on windows was preventing recursive calls to programs like cargo from being able to use the rustup proxies.There was a call for testing at https://internals.rust-lang.org/t/help-test-windows-behavior-between-rustup-and-cargo/20237 and https://users.rust-lang.org/t/help-test-windows-behavior-between-rustup-and-cargo/106145. AFAIK, there have not been any indications of anyone having problems.
Fixes #3036