Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧊 Put glacier on ice 🧊 #1459

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

fmease
Copy link
Member

@fmease fmease commented May 22, 2024

Archives rust-lang/glacier, @rust-lang/wg-triage.

Glacier has been considered dead for a while now. See also this Zulip topic.

It's been partially superseded by tests/crashes in rust-lang/rust.
Thanks, @matthiaskrgr, for the work you put into the new system!
See also rust-lang/rust#122997.

Verified

This commit was signed with the committer’s verified signature.
WhiteMinds WhiteMind
@fmease fmease changed the title :icePut glacier on ice 🧊 🧊 Put glacier on ice 🧊 May 22, 2024
@fmease

This comment was marked as resolved.

@jackh726
Copy link
Member

Is this enough to archive it? Neat.

@matthiaskrgr does this sound good to you?

@matthiaskrgr
Copy link
Member

Its worth noting that test/crashes is not a drop-in replacement for glacier, as in glacier you can also have shellscript or test for crashes in rustdoc/rustfmt, so not all of the tests have been ported over.
Besides that LGTM. :)

@fmease
Copy link
Member Author

fmease commented May 23, 2024

Right, that's why I wrote "partially superseded". I've discussed this with Matthias and we came to the conclusion that it should be relatively straightforward to impl "tests/crashes/{rustdoc,rustfmt,run-make}/" eventually to complete the transition. This shouldn't be blocking.

@jackh726 jackh726 merged commit a2fda92 into rust-lang:master May 23, 2024
1 check passed
@fmease fmease deleted the archive-glacier branch May 23, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants