-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix glacier command #949
Fix glacier command #949
Conversation
It was fetching the HTML rather than the raw source; see rust-lang/glacier#530 for an example.
@Mark-Simulacrum Could you review this? Thanks! |
Thanks! Looking forward to using the command now :) |
Hmm, it doesn't seem to be working: rust-lang/rust#78632 (comment) |
Why did you sent the command twice ? |
Because the first time it didn't work – you need to include @Mark-Simulacrum did you see anything in the logs that would explain why rustbot silently failed? |
It probably failed because it wasn't able to recreate a branch with the same name. (The branch having been created by your first command) See rust-lang/glacier#231 (comment) and rust-lang/glacier#231 (comment) |
I don't have time right now to track down logs unfortunately, but @kellda's theory looks like the right one. |
It was fetching the HTML rather than the raw source;
see rust-lang/glacier#530 for an example.