[Fixed] Bootloader v0.9.17 seems to be broken on Rust nightly-2021-05-20

[phil-opp]

I just noticed this in the automated CI runs for the blog_os project: https://github.com/phil-opp/blog_os/runs/2626134888?check_suite_focus=true#step:12:47

When trying to run cargo +nightly-2021-05-20 run, the following error occurs:

The error message is "Failed to load rest of bootloader" and happens in the early assembly stages.

I'm not sure what's going wrong yet, I will update this issue when I find the cause.

[phil-opp]

Diff between the working and broken nightly: rust-lang/rust@4e3e6db...f94942d

[bjorn3]

--gc-sections is now only passed if "linker-is-gnu": true is used inside the target spec (rust-lang/rust#85274). The blog os target spec doesn't mention it. Maybe the first stage is too big without --gc-sections?

[phil-opp]

@bjorn3 Ah thanks, I think that's likely the reason. I'll push a fix in a moment.

[phil-opp]

I opened #168 with a fix.

[phil-opp]

Fix published as v0.9.18. A cargo update -p bootloader should be enough to fix this issue in downstream crates.