Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs on versioning and publishing releases to CONTRIBUTING.md #74

Merged
merged 2 commits into from
May 10, 2019
Merged

Add docs on versioning and publishing releases to CONTRIBUTING.md #74

merged 2 commits into from
May 10, 2019

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Apr 10, 2019

@fitzgen fitzgen mentioned this pull request Apr 10, 2019
Closed
@thedodd
Copy link

thedodd commented Apr 10, 2019

LGTM! +1

Pauan
Pauan approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything holding this back, or can we get it merged?

@fitzgen fitzgen merged commit 152f346 into rustwasm:master May 10, 2019
@fitzgen
Copy link
Member Author

fitzgen commented May 10, 2019

Think it just got forgotten!

@fitzgen fitzgen deleted the publishing-and-versioning branch May 10, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@Pauan Pauan Pauan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Questions about versioning Gloo
4 participants
@fitzgen @thedodd @alexcrichton @Pauan