Skip to content

Fix support for synchronous animation queues #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2017
Merged

Fix support for synchronous animation queues #1376

merged 1 commit into from
Aug 18, 2017

Conversation

dtex
Copy link
Collaborator

@dtex dtex commented Aug 17, 2017

Fixes #1361

@rwaldron rwaldron merged commit af8494b into rwaldron:master Aug 18, 2017
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 12, 2017
@dtex
Fix sycnchronous animation queues
c00a5a6 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 13, 2017
@dtex
Fix sycnchronous animation queues
7b261f1 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 13, 2017
@dtex
Fix sycnchronous animation queues
5dcb636 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
@dtex dtex mentioned this pull request Oct 13, 2017
Merged
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 13, 2017
@dtex
Fix sycnchronous animation queues
f48f6db 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 17, 2017
@dtex
Fix sycnchronous animation queues
264e122 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 17, 2017
@dtex
Fix sycnchronous animation queues
8f03124 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 17, 2017
@dtex
Fix sycnchronous animation queues
fcb3005 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 18, 2017
@dtex
Fix sycnchronous animation queues
b048129 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 19, 2017
@dtex
Fix sycnchronous animation queues
c242f49 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
dtex added a commit to dtex/johnny-five that referenced this pull request Oct 19, 2017
@dtex
Fix sycnchronous animation queues
43f9b03 
rwaldron#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
rwaldron pushed a commit that referenced this pull request Dec 8, 2017
@dtex @rwaldron
Fix sycnchronous animation queues
73f6a7c 
#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.
@ScreamZ ScreamZ mentioned this pull request Oct 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtex @rwaldron