Skip to content

Include setNativeToken #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
smol-ninja opened this issue Mar 14, 2025 · 1 comment
Open

Include setNativeToken #18

smol-ninja opened this issue Mar 14, 2025 · 1 comment
Labels
effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@smol-ninja
Copy link
Member

Context: https://github.com/sablier-labs/company-discussions/discussions/115#discussioncomment-12504570
@smol-ninja smol-ninja added effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Mar 14, 2025
@PaulRBerg PaulRBerg changed the title Include setGasTokenAddress Include setNativeToken Mar 28, 2025
@smol-ninja
Copy link
Member Author

Same question as #13 (comment).

Given we now have the code for collect-fee, it will be easy to include it as well now. But the question is since default fee can only be set by the admin, how would we do it without exposing the admin's private key or more complicated if its a multisig.

And if we only need the calldata for the tx, we can use cast sig from Foundry CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smol-ninja