Skip to content

[WIP] feat: collect fees script #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] feat: collect fees script #20

wants to merge 4 commits into from

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Mar 31, 2025 •
edited
Loading

Closes https://github.com/sablier-labs/command-center/issues/118

To do

  • Polish code
  • Handle errors
  • Implement progress tracking in .db.log file
  • Make it a CLI
  • Automate collect-fee CLI through Github CI
  • Update readme.md
  • Feature requests from PRB

@smol-ninja smol-ninja changed the title feat: collect fees script [WIP]feat: collect fees script Mar 31, 2025
@smol-ninja smol-ninja changed the title [WIP]feat: collect fees script [WIP] feat: collect fees script Mar 31, 2025
@smol-ninja smol-ninja force-pushed the script/collect-fee branch 4 times, most recently from ddf15f3 to cb876ae Compare April 2, 2025 12:35
@smol-ninja
refactor code with better error handlings
21955dd 
add env.example and deployments.json

dry'ify code

dryify code

refactor code
@smol-ninja smol-ninja force-pushed the script/collect-fee branch from cb876ae to 21955dd Compare April 2, 2025 16:53
This was referenced Apr 2, 2025
Closed
Open
@PaulRBerg
Copy link
Member

PaulRBerg commented Apr 7, 2025 •
edited
Loading

Feature requests for the broadcast JSON file:

  • Remove the root broadcasts object; starting with the array is fine
  • Rename fee_collected to fee_collected_wei
  • Add a new field fee_collected_raw (using ETH as the denomination)
    • Note: feel free to suggest a better name if you find one
  • Add a new explorer_url field (a link to the tx on a blockchain explorer)

@PaulRBerg
Copy link
Member

And another feature request, this time a very important one!

  • Calculate the USD value of the collected fee and specify it in a new field fee_collected_usd

@smol-ninja smol-ninja mentioned this pull request Apr 16, 2025
Merged
5 tasks
smol-ninja and others added 2 commits April 16, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smol-ninja @PaulRBerg