Skip to content

Commit 16c78ca

Browse files
author
Release Manager
committed
gh-36373: Enable conda ci for all PRs and remove experimental label <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Using conda to install all sage dependencies is pretty stable and has been long enough in "experimental mode". We remove here the experimental flag and in order to make sure that the workflow is not breaking enable the conda-ci on all PRs. This also provides a) faster feedback as the whole build+test takes only about 1.5h (which is less time then what only the "incremental build" currently takes) and b) tests that the code is working on all supported python versions. The last remaining failing tests under linux are temporarily disabled in #36372. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #36373 Reported by: Tobias Diez Reviewer(s): Matthias Köppe
2 parents 17f07d5 + e7d0a44 commit 16c78ca

File tree

2 files changed

+3
-24
lines changed

2 files changed

+3
-24
lines changed

.github/workflows/ci-conda.yml

+2-20
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,6 @@ on:
77
branches:
88
- 'public/build/**-runci'
99
pull_request:
10-
types:
11-
# Defaults
12-
- opened
13-
- synchronize
14-
- reopened
15-
# When a CI label is added
16-
- labeled
1710
workflow_dispatch:
1811
# Allow to run manually
1912

@@ -27,20 +20,9 @@ jobs:
2720
name: Conda
2821
runs-on: ${{ matrix.os }}
2922

30-
# Run on push, workflow dispatch and when certain labels are added or are present
31-
if: |
32-
github.event_name != 'pull_request' ||
33-
((github.event.action != 'labeled' &&
34-
(contains(github.event.pull_request.labels.*.name, 'c: packages: standard') ||
35-
contains(github.event.pull_request.labels.*.name, 'c: packages: optional') ||
36-
contains(github.event.pull_request.labels.*.name, 's: run conda ci'))) ||
37-
(github.event.action == 'labeled' &&
38-
(github.event.label.name == 'c: packages: optional' ||
39-
github.event.label.name == 'c: packages: standard' ||
40-
github.event.label.name == 's: run conda ci')))
41-
4223
strategy:
43-
fail-fast: false
24+
fail-fast: ${{ github.event_name == 'pull_request' }}
25+
max-parallel: ${{ github.event_name == 'pull_request' && 2 || 6 }}
4426
matrix:
4527
os: [ubuntu-latest, macos-latest]
4628
python: ['3.9', '3.10', '3.11']

src/doc/en/installation/conda.rst

+1-4
Original file line numberDiff line numberDiff line change
@@ -93,17 +93,14 @@ from source as follows:
9393

9494
.. _sec-installation-conda-develop:
9595

96-
Using conda to provide all dependencies for the Sage library (experimental)
96+
Using conda to provide all dependencies for the Sage library
9797
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
9898

9999
You can build and install the Sage library from source, using conda to
100100
provide all of its dependencies. This bypasses most of the build
101101
system of the Sage distribution and is the fastest way to set up an
102102
environment for Sage development.
103103

104-
Note that this is still an experimental feature and may not work as
105-
intended.
106-
107104
Here we assume that you are using a git checkout.
108105

109106
- Optionally, set the build parallelism for the Sage library. Use

0 commit comments

Comments
 (0)