-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sympy minus infinity doesn't convert to Sage #12345
Comments
Changed keywords from none to sd40.5 |
comment:1
Straightforward fix and test of the original case as an integral. |
comment:2
Umm, even without this patch I get
Am I missing something? How is that an indirect doctest? That said, the integral works fine now and the tests pass. |
Reviewer: Karl-Dieter Crisman |
Author: Douglas McNeil |
comment:3
Ah, those were merely mirroring the +oo cases. Really they were only testing whether the negation worked; it was the integral test which was really verifying the success. However, we can test it explicitly by adding.
which fails without the patch. Modified to incorporate this. |
comment:4
Positive review. |
Attachment: trac_12345_minusinfinity_sympyfication.patch.gz add |
Merged: sage-5.1.beta4 |
comment:7
I think this ticket is already fixed? |
Commit: |
gh-35141: Revise the PR template <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> ### 📚 Description Made small edits to the PR template, making it concise and tidy overall. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on Depends on #12345: short description why this is a dependency Depends on #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35141 Reported by: Kwankyu Lee Reviewer(s): Kwankyu Lee, Tobias Diez
gh-35355: partial fix for E221 (to be continued) <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description Partial fix for pycodestyle E221, done using autopep8. E221 multiple spaces before operator <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35355 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
gh-35356: Fix documentation deployment <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description The update #35184 broke the docs upload. Hopefully this is fixed with this PR. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35356 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Kwankyu Lee
gh-35366: Many more namespace packages – follow up <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> Follow-up from #35322. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35366 Reported by: Matthias Köppe Reviewer(s): Gonzalo Tornaría
gh-35372: Replace more `.all` imports <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description This is a follow-up on: - #35110 As preparation for #35322, which is changing more packages to implicit namespace packages, we remove `.all` imports from these packages throughout the Sage library. This is part of: - #29705 <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> - Depends on #35418 - Depends on #35358 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35372 Reported by: Matthias Köppe Reviewer(s): Gonzalo Tornaría
gh-35377: build/pkgs/openblas/spkg-configure.m4: Reject version 0.3.22 <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description openblas 0.3.22 is broken, see: - #35371 - scipy/scipy#18208 - OpenMathLib/OpenBLAS#3976 We reject it. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35377 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri
sagemathgh-39467: Disable broken and outdated CI <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Many of the CI runs after a new release are failing, for months now, see eg https://github.com/sagemath/sage/actions/runs/12979684199/job/3621812 6145. Some of these failures are genuine (eg a certain package cannot be built on a certain system) and some others are due to constraints of the build system (eg running out of free space). Since there is very little point in senselessly burning energy, all runs that were failing for the last releases are disabled. Once the underlying issues are fixed, they can be easily be re-enabled. Moreover, the "minimal" runs where only a couple of systems packages are installed and most are build using sage are removed, keeping only the "standard" where all available system packages (corresponding to standard sage packages) are installed. New test run: https://github.com/tobiasdiez/sage/actions/runs/1319937223 2/job/36847711005 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#39251 (to resolve merge conflicts) <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39467 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Kwankyu Lee, Tobias Diez, user202729
sagemathgh-39562: Meson: Remove unused build dependencies ppl and fplll <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Remove ppl and fplll as (build) dependencies according to sagemath#39548 (comment) since they are only used via their python wrappers. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39562 Reported by: Tobias Diez Reviewer(s): Gonzalo Tornaría, Michael Orlitzky
sagemathgh-39571: Bump pillow and cffi This bumps pillow and cffi to the latest versions. I had trouble building older ones on macOS M1 machine ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39571 Reported by: Dima Pasechnik Reviewer(s): David Coudert, Kwankyu Lee
sagemathgh-39593: remove traces of experimental package `modular_decomposition` The experimental package `modular_decomposition` has been removed years ago. The upstream source code was buggy. This PR removes forget traces in `build/pkgs/modular_decomposition`. After running `./bootstrap`, I don't see anymore traces of `modular_decomposition` in the options listed by `configure --help`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39593 Reported by: David Coudert Reviewer(s): Frédéric Chapoton
sagemathgh-39602: bump executing to 2.2.0 It's in particular needed to fix ipython error handling with Python 3.13 This will fix sagemath#39591 see sagemath#39591 (comment) by Tobias Diez ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39602 Reported by: Dima Pasechnik Reviewer(s):
sagemathgh-39621: Fix documentation diff for cython() As discussed in sagemath#38946 (comment) , this hides an irrelevant entry in documentation diff. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39621 Reported by: user202729 Reviewer(s): Travis Scrimshaw
sagemathgh-39623: Fix spacing for documentation Partially discussed in sagemath#39555. Meanwhile I find a few more. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39623 Reported by: user202729 Reviewer(s): Frédéric Chapoton
sagemathgh-39632: Implement matrix Schubert variety ideals <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We provide an implementation that returns the defining ideal of the matrix Schubert variety corresponding to the permutation `w` using the Fulton generators for the ideal. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39632 Reported by: Travis Scrimshaw Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
sagemathgh-38879: Run meson-ci for MacOS <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Activate CI builds using meson for macos. In the process, update the conda env lock files and fix a deprecation warning in new IPython versions (`NoColor` > `nocolor`) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#37447: for the updated conda lock files - sagemath#38749: for the update to pari <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38879 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
sagemathgh-39069: Mention .coerce() method in coercion tour I feel it's too hard to discover previously. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39069 Reported by: user202729 Reviewer(s): Frédéric Chapoton
sagemathgh-39221: new implementation of method `is_transitive` with linear memory space The previous version of method `is_transitive` was building the distance matrix of the digraph and so had memory usage in $O(n^2 + m)$. We change that to a version with memory usage in $O(n + m)$. In addition, this new version is faster for non-transitive digraphs. Before ```sage sage: D = digraphs.Circuit(4) sage: D.is_transitive() False sage: %timeit D.is_transitive() 8.01 µs ± 35.7 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each) sage: D = digraphs.RandomDirectedGNP(30,.2) sage: D.dig6_string() ']AOGb?dA?pG?S?@?OPIGG???_?O?GC??W_H?BCjaJJA?gO@?A??_?VDHG_ACCiBU?O`HaUC ?kAAD@_AAJErW_G_ICCGa@?S@Oo?IC????DoCQ?Q?@?_@g?O?C?aAGK??o?cKO_W???A?G?G o?H`??Co' sage: D.is_transitive() False sage: %timeit D.is_transitive() 54.3 µs ± 167 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) sage: D = digraphs.DeBruijn(5, 2) sage: D.is_transitive() False sage: %timeit D.is_transitive() 80.6 µs ± 116 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) sage: D = digraphs.RandomDirectedGNP(20,.2).transitive_closure() sage: D.dig6_string() 'S^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~w' sage: D.is_transitive() True sage: %timeit D.is_transitive() 56 µs ± 181 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) ``` With this PR ```sage sage: D = digraphs.Circuit(4) sage: D.is_transitive() False sage: %timeit D.is_transitive() 6.63 µs ± 26.8 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each) sage: D = DiGraph(']AOGb?dA?pG?S?@?OPIGG???_?O?GC??W_H?BCjaJJA?gO@?A??_?VDHG_ACCiB U?O`HaUC?kAAD@_AAJErW_G_ICCGa@?S@Oo?IC????DoCQ?Q?@?_@g?O?C?aAGK??o?cKO_W ???A?G?Go?H`??Co') sage: D.is_transitive() False sage: %timeit D.is_transitive() 46.7 µs ± 88.4 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) sage: D = digraphs.DeBruijn(5, 2) sage: D.is_transitive() False sage: %timeit D.is_transitive() 73.8 µs ± 116 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) sage: D = DiGraph('S^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~z~~~^~~ z~~~^~~z~~~^~~w') sage: D.is_transitive() True sage: %timeit D.is_transitive() 58.6 µs ± 118 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) ``` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39221 Reported by: David Coudert Reviewer(s): Frédéric Chapoton
sagemathgh-39274: Remove `--fiximports` helper It did its job; the remaining imports are okay (or would need manual work anyway). This is part of trying to eliminate most in `misc`. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39274 Reported by: Tobias Diez Reviewer(s):
sagemathgh-39296: fix the behavior for immutable graphs in methods related to isomorphisms in `sage/graphs/generic_graph.py` Following sagemath#39280 and discussions in sagemath#39177, we add parameter `immutable` to methods related to graph isomorphisms in `sage/graphs/generic_graph.py` and `bliss.pyx`: - `canonical_form` - `automorphism_group` - `is_isomorphic` - `graph_isom_equivalent_non_edge_labeled_graph` - and also `cayley_graph` We also fix the behavior of method `canonical_label` in `BipartiteGraph`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39296 Reported by: David Coudert Reviewer(s): Frédéric Chapoton
sagemathgh-39364: bump gmpy2 to 2.2.1 we now have a new stable version of gmpy2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39364 Reported by: Dima Pasechnik Reviewer(s): Kwankyu Lee
sagemathgh-39444: Improve is_empty and is_finite in a few cases * `is_empty` for cartesian_product now returns True as long as some factor can be determined to be empty, even if other factors' emptiness is unknown. * `is_finite` for cartesian_product now correctly return "unknown" in case (unknown empty set × infinite set). * as a consequence of the above, `is_empty` must be provided for e.g. `FiniteWords("ab")` for tests to pass. (Unfortunately Sage has two different functions `is_empty` and `__bool__` that does almost the exact same thing, I guess we will have to live with it.) * `is_empty` for union of two sets now returns False as long as the first set is nonempty, regardless of the second set. (also performance optimization, no need to compute the cardinality.) * `LazyFamily` now has `is_finite` implemented in more cases. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39444 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
sagemathgh-39622: Fix CI documentation diff As discussed in sagemath#39542 . Without this, the "Changes is ready!" feature will be broken. Also remove some outdated documentation (the requirement list in update- conda was wrong (toml missing), I just refer to README.md which contains the correct list) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39622 Reported by: user202729 Reviewer(s): Kwankyu Lee, Tobias Diez, user202729
sagemathgh-39645: Remove deprecated PseudoQuaternionicProjectivePlane alias <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Eliminate the deprecated alias for PseudoQuaternionicProjectivePlane and its associated warning. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39645 Reported by: Tobias Diez Reviewer(s): Frédéric Chapoton
sagemathgh-39652: pythran 0.17.0, switch to wheel Previous version getting obsolete, also, a preparation for scipy update <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39652 Reported by: Dima Pasechnik Reviewer(s): David Coudert
sagemathgh-39653: ninja_build: Update to 1.12.1 a long overdue update of ninja ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39653 Reported by: Dima Pasechnik Reviewer(s): David Coudert
sagemathgh-39654: Pybind11, version 2.13.6 version bump needed for scipy update ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39654 Reported by: Dima Pasechnik Reviewer(s): David Coudert
sagemathgh-39655: update numpy to 2.2.3, scipy to 1.15.2 this is long overdue update. It needs building tools bumped, too, thus dependencies ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies build tools need a bump - sagemath#39652 : pythran - sagemath#39653 : ninja - sagemath#39654: pybind11 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39655 Reported by: Dima Pasechnik Reviewer(s): David Coudert
sagemathgh-39664: Add some 'not tested' marks to avoid CI failure As in the title. I don't think there's any advantage in running the test again. There's only a very small risk of the fixer forget to delete the marker, but it seems like a nonexistent issue (whichever pull request that fix it should also remove the `# not tested`) At least for those that doesn't segmentation fault or hang. (For those who do the only solution I can think of is sagemath#39539 ) Side note: not sure what's a good solution to this. Maybe we can do sagemath#39470 instead? (but then it doesn't apply to meson…) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39664 Reported by: user202729 Reviewer(s):
sagemathgh-39670: CI: Remove broken Linux Mint and openSUSE runs <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Remove the following broken CI runs (https://github.com/sagemath/sage/actions/runs/13750937379): - Linux Mint: fails due to an error in the retrofit script ``` touch: cannot touch 'build/make/Makefile': No such file or directory rm: cannot remove '/new/.git': Directory not empty ``` - openSUSE with python 3.10 fails with `checking ... whether /usr/bin/python3.10 is good... no, Python 3.10.16 is too old` can probably be removed compltely; at least sage-lib no longer supports 3.10, not sure about sage-the-distro. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39670 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
sagemathgh-39675: update trove_classifiers to 2025.3.3 This is needed for Pillow 11 to build in some cases. The symptom that your trove_classifier is too old is a cryptic error ``` [spkg-install] ValueError: invalid pyproject.toml config: `project.classifiers[1]`. [spkg-install] configuration error: `project.classifiers[1]` must be trove-classifier ``` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39675 Reported by: Dima Pasechnik Reviewer(s):
sagemathgh-39680: sphinxcontrib-htmlhelp 2.1.0 urgently needed for python 3.13 support. See https://groups.google.com/g/sage-devel/c/lr03GlRBr9g/m/M8nTdw_5AQAJ - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39680 Reported by: Dima Pasechnik Reviewer(s):
sagemathgh-39686: update sphinxcontrib packages This is a follow up to sagemath#39577 where sphinx was update but not the sphinxcontrib packages. This causes breakages for some users. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39680 deals with one the packages that would be covered by this PR <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39686 Reported by: François Bissey Reviewer(s):
sagemathgh-39711: Allow negative shift for flint rational polynomial Fixes sagemath#39710 Note that the behavior is compatible with the existing behavior of e.g. `ZZ[]`. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39711 Reported by: user202729 Reviewer(s): Travis Scrimshaw
sagemathgh-39724: Fixing the cartesian product of a CFM and a generic object. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#39723 by dispatching to the appropriate class based on input. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39724 Reported by: Travis Scrimshaw Reviewer(s): Frédéric Chapoton
sagemathgh-39732: Update docstring on E2 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Update docstring on the weight 2 Eisenstein series - replace with specific numbers for $k = 2$. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> None URL: sagemath#39732 Reported by: Seewoo Lee Reviewer(s): Frédéric Chapoton
sagemathgh-39738: update msolve to version 7.5 a routine update of msolve - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39738 Reported by: Dima Pasechnik Reviewer(s): Frédéric Chapoton
See this ask.sagemath.org question for background.
CC: @certik @rwst
Component: symbolics
Keywords: sd40.5
Author: Douglas McNeil
Branch/Commit: u/akhi/sympy_minus_infinity_doesn_t_convert_to_sage @
52db42b
Reviewer: Karl-Dieter Crisman
Merged: sage-5.1.beta4
Issue created by migration from https://trac.sagemath.org/ticket/12345
The text was updated successfully, but these errors were encountered: