You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gh-35554: Laurent polynomial/series modularization fixes
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes#12345", use "Add a new method to
multiply two integers" -->
### 📚 Description
<!-- Describe your changes here in detail. -->
We remove several obstacles to modularization:
- `sage.data_structures.stream` importing from `sage.combinat.sf`
- eager module-level imports in `sage.rings.bigoh`, importing
`LaurentSeries`, `PuiseuxSeries`, padics.
- `LaurentSeriesRing._element_constructor_` unconditionally importing
`sage.libs.pari.all` just for an `isinstance` test
- import of `factorial` from `sage.functions` (only the version from
`sage.arith` is needed)
- multivariate implementation of Laurent polynomials (with compile-time
dependency on `sage.matrix`) mixed with the univariate implementation
Also adding `# optional` tags for the doctests that depend on
`sage.rings.finite_rings`, `sage.symbolic`.
<!-- Why is this change required? What problem does it solve? -->
Part of:
- #29705
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: #35554
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
0 commit comments