Too many functions from databases/cremona.py are exported globally

[JohnCremona]

In sage/databases/all.py:

from cremona import CremonaDatabase, \
     cremona_letter_code, parse_cremona_label, \
     old_cremona_letter_code, is_optimal_id

but only the first of these should be global.

Component: elliptic curves

Keywords: databases cremona

Author: Mike Hansen

Reviewer: Robert Miller, Aly Deines

Merged: sage-4.6.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/10107

[mwhansen]

Attachment: trac_10107.patch.gz

[mwhansen]

Author: Mike Hansen

[mwhansen]

comment:1

This needs to be coordinated with #9907.

[JohnCremona]

comment:2

I don't really understand the connection between this and #9907, or what most of the patch is for! Is it just that you don't want to get rid of a command which used to work from a sage: prompt without deprecating it first?

[mwhansen]

comment:3

This patch has from sage.misc.misc import sage_wraps while the patch at #9907 moves sage_wraps from sage.misc.misc to sage.misc.decorators.

Yes, most of the patch is to deprecate using those functions from the top level before removing them. Since this shared some functionality with preexisting code, the idea was to unify the code.

[rlmill]

comment:4

If I apply #6094, #9907, #9919, and #10107 together on top of sage-4.6, all long tests pass. The code looks good.

[rlmill]

Reviewer: Robert Miller

[jdemeyer]

comment:5

I get various doctest errors in sage/databases/cremona.py:

File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.6.1.alpha2/devel/sage-main/sage/databases/cremona.py", line 102:
    sage: is_optimal_id('b1')
Expected:
    True
Got:
    doctest:1: DeprecationWarning:
    Using is_optimal_id from here is deprecated.  If you need to use it, please import it directly from sage.databases.cremona.
    True

and several more like this.

[jdemeyer]

Changed keywords from databases to databases cremona

[JohnCremona]

Attachment: trac_10107-fix.patch.gz

replaces previous

[JohnCremona]

comment:6

The new patch deals with this (replaces previous).

[adeines]

Changed reviewer from Robert Miller to Robert Miller, Alyson Deines

[jdemeyer]

Merged: sage-4.6.1.alpha2

[jdemeyer]

Changed reviewer from Robert Miller, Alyson Deines to Robert Miller, Aly Deines

[eviatarbach]

comment:11

It's been over two years since these were deprecated; can they be removed from the global namespace?

[JohnCremona]

comment:12

I am happy with that. I guess it needs a new ticket. Will you make one and reference it from here?

[eviatarbach]

comment:13

Okay, good. The new ticket is #14642.

[jdemeyer]

comment:14

Interestingly, this ticket is the one which introduced deprecated_callable_import. Given that I see no advantage of deprecated_callable_import over a lazy import with deprecation, I plan to remove deprecated_callable_import in #22796.