Singular does not state return type of main() functions

[ohanar]

This breaks building with clang.

I've posted an spkg fixes this (and #12441) at http://wstein.org/home/ohanar/clang-port/sage-5.0.beta1-src/spkg/standard/singular-3-1-3-3.p5.spkg. (This is a review spkg in case there are more issues with clang down the road.)

Component: packages: standard

Keywords: spkg

Author: R. Andrew Ohana, Leif Leonhardy

Branch/Commit: d45f16b

Reviewer: Leif Leonhardy, Jean-Pierre Flori, Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/12442

[ohanar]

Attachment: singular-main-returns.patch.gz

for review purposes

[nexttime]

Work Issues: Rebase the spkg on the p6 from #12680.

[nexttime]

Reviewer: Leif Leonhardy

[nexttime]

comment:2

FWIW, otherwise patch looks good... ;-)

[nexttime]

Changed keywords from none to spkg

[nexttime]

Author: R. Andrew Ohana

[jdemeyer]

comment:3

Has this been reported upstream (http://www.singular.uni-kl.de:8002/trac/newticket)?

[nexttime]

Changed work issues from Rebase the spkg on the p6 from #12680. to Rebase the spkg on the p6 from #14429.

[nexttime]

Changed work issues from Rebase the spkg on the p6 from #14429. to Rebase the spkg on the one from #14429.

[nexttime]

comment:6

Looks like there were meanwhile more instances (in Singular 3-1-5), although at least some of them are in test code which does not necessarily get built.

[nexttime]

Changed work issues from Rebase the spkg on the one from #14429. to Rebase the spkg on the latest one (presumably 3-1-5.p8).

[nexttime]

comment:7

Just to make you aware of #14737 (new spkg presumably coming up soon).

[vbraun]

comment:10

Might be fixed by #14333, try sage-6.2.beta0 when its out and report back...

[nexttime]

comment:13

Replying to @vbraun:

Might be fixed by #14333, try sage-6.2.beta0 when its out and report back...

Nope, it isn't:

libparse.l:967:1: error: C++ requires a type specifier for all declarations

(as of Sage 6.2 / singular-3.1.6.p1)

[nexttime]

To be put into build/pkgs/singular/patches/.

[nexttime]

comment:14

Attachment: singular-3.1.6-no_return_type.patch.gz

Replying to @nexttime:

Replying to @vbraun:

Might be fixed by #14333, try sage-6.2.beta0 when its out and report back...

Nope, it isn't:

libparse.l:967:1: error: C++ requires a type specifier for all declarations

(as of Sage 6.2 / singular-3.1.6.p1)

New patch for Singular 3.1.6 attached. (No branch [yet], also because of #13331.)

[nexttime]

comment:15

Anyway...

[nexttime]

Changed work issues from Rebase the spkg on the latest one (presumably 3-1-5.p8). to none

[nexttime]

Changed author from R. Andrew Ohana to R. Andrew Ohana, Leif Leonhardy

[jpflori]

comment:17

Anyone feels like reviewing this if I create a branch?
Then I'll move to #13331.

[vbraun]

comment:18

This is fixed in Singular-4.0

[jpflori]

comment:19

Great, but is it officially released (I'm aware there is tarball available) and is there anyone working on porting Sage to the new Singular interface?

[vbraun]

comment:20

Well the webpage still points to 3-1-6. If you want to patch 3-1-6 in the interim then go ahead, all I'm saying is that this will fix itself sooner or later. How much of a priority is building Sage with clang?

[jpflori]

comment:21

Actually I don't care, but I'd like to get #13331 in and this one was mentioned there.

[jpflori]

Changed reviewer from Leif Leonhardy to Leif Leonhardy, Jean-Pierre Flori

[jpflori]

comment:22

Still builds fine with the trivial patch, and it makes sense to me.

I assume this was actually tested with clang, so positive review.

[jpflori]

Branch: u/jpflori/ticket/12442

[jpflori]

New commits:

d45f16b

Let Singular build with clang.

[jpflori]

Commit: d45f16b

[vbraun]

Changed reviewer from Leif Leonhardy, Jean-Pierre Flori to Leif Leonhardy, Jean-Pierre Flori, Volker Braun

[vbraun]

Changed branch from u/jpflori/ticket/12442 to d45f16b