singular-3-1-6 is out #14333

SnarkBoojum · 2013-03-22T07:54:49Z

http://www.singular.uni-kl.de/index.php/news/release-of-singular-3-1-6.html

Sage should probably upgrade to this version; it won't be painless though, since my experiments show that what in the changelog is lightly documented as "interface to iiMake_proc changed" (in the "Internal changes" section) -- impacts sage.
The API for iiMake_proc changed from

sleftv * iiMake_proc(idhdl pn, package pack, sleftv* sl);

to

BOOLEAN iiMake_proc(idhdl pn, package pack, sleftv* sl);

Probably also take care of #12442.

Use git branch.

Upstream tarball at: http://sage.math.washington.edu/home/jpflori/upstream/singular-3.1.6.tar.bz2

Depends on #13770

CC: @jpflori

Component: packages: standard

Keywords: spkg, sd53

Author: Burcin Erocal

Branch/Commit: u/jpflori/ticket/14333 @ dd46991

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/14333

The text was updated successfully, but these errors were encountered:

nexttime · 2013-03-22T13:03:00Z

Changed keywords from none to spkg

nexttime · 2013-03-22T13:22:58Z

comment:2

The patch from #14295 would have to get updated as well (as there's now one more instance of calling floor() with an int; they also added some superfluous casts, so the patch probably wouldn't apply anyway).

SnarkBoojum · 2013-03-22T14:33:53Z

comment:3

Wasn't that patch already updated before you submitted it on upstream's trac?

nexttime · 2013-03-22T15:11:03Z

comment:4

Replying to @SnarkBoojum:

Wasn't that patch already updated before you submitted it on upstream's trac?

Pardon?

(I haven't submitted a patch upstream, but only a bug report. The patch from #14295 is of course against 3-1-5, our current version, not 3-1-6.)

SnarkBoojum · 2013-03-22T15:23:54Z

comment:5

Oh, sorry, indeed.

burcin · 2013-05-29T10:59:34Z

comment:7

I'm modifying the ticket priority since it fixes some problems with multivariate polynomial factorization (#14658).

nexttime · 2013-05-30T17:10:17Z

comment:8

Replying to @burcin:

I'm modifying the ticket priority since it fixes some problems with multivariate polynomial factorization (#14658).

Upgrading Singular is still (hopefully) an enhancement, not a defect. (Unless you change the ticket's subject...)

nexttime · 2013-06-13T15:11:01Z

comment:10

Just to make you aware of #14737.

jpflori · 2013-07-11T11:32:40Z

comment:11

It would also be nice to backport the fix needed by NTL 6.0.0: see #14876 and https://groups.google.com/d/msg/libsingular-devel/aiMvEnN8qyg/cIFUsOXxK_MJ

jdemeyer · 2013-08-26T20:41:53Z

comment:14

I'm looking into this...

jdemeyer · 2013-08-26T20:41:53Z

Dependencies: #13770

burcin · 2013-09-28T17:24:53Z

Attachment: trac_14333-singular_function_interface.patch.gz

burcin · 2013-09-28T17:30:54Z

Author: Burcin Erocal

burcin · 2013-09-28T17:30:54Z

comment:16

I uploaded a patch to take care of the API change.

New (preliminary) spkg adds two commits from singular git (1 and 2) to add compatibility with NTL 6 (#14867) and some template instantiation errors from gcc 4.7. I didn't check if the NTL stuff works.

burcin · 2013-09-28T17:30:54Z

Changed keywords from spkg to spkg, sd53

jm58660 · 2013-10-30T12:26:34Z

comment:19

FYI: There is still bug in Singular 3.1.6. At least this one sometimes (say once for every five tries) fails to factorize:

(-4*c*d + 8*d^2 + 12*f^2 + 8*a)*(8*b*c - 12*c + 4*f)*(3*a*c + 3*b*c - 
3*a*d + 33*d^2 - 3*f)*(-4*a*b - 4*b*d + 140*d^2 - 4*d*f - 4*a)*(4*a*b - 
8*b*d - 12*d^2 - 12*c*f - 8)*(-21*b*c - 3*b*d - 222*d^2 - 6*d*f - 
39*f)*(16*a*d + 128*b*d - 2)*(8*b*c + 4*c^2 - 4*b*f + 12*f)*(4*a*b + 4*b*c 
- 2*a*f + 6*f^2 - 2*b)*(-48*b^2 + 8*c*d + 144*c)*(-3*b^2 + 4*c^2 - b*d + 
f^2 + 3*a)*(4*c^2 + 4*b*d - 4*d^2 + 12*a*f)

I have already reported this, and version 4.0 should contain correction.

burcin · 2013-10-30T14:29:57Z

comment:20

Replying to @jm58660:

I have already reported this, and version 4.0 should contain correction.

Changing our libSingular interface to be compatible with version 4.0 is a major effort. We should backport the fix or find out the corresponding patch in the Singular master branch and add it to the spkg.

Jori, I haven't seen any responses to the email you sent to [email protected]. Do you have the commit id for the fix by any chance?

jm58660 · 2013-10-30T15:51:47Z

comment:21

Replying to @burcin:

Jori, I haven't seen any responses to the email you sent to [email protected]. Do you have the commit id for the fix by any chance?

I have received answers from Martin Lee. Three weeks ago he wrote "I hope that we will release a new version of Singular in the next weeks". Unfortunately I don't have id nor code; I don't know if fix for this is released at all, Martin just said that this is easy to fix.

SnarkBoojum · 2013-10-30T15:57:43Z

comment:22

Changing the libSingular interface might be a major effort, but backporting fixes from upstream is probably not a minor effort either... the best spkg is a "./configure && make && make install"!

jpflori · 2013-10-30T16:40:17Z

comment:23

Is there any reason not to update to 3-1-6 (and this ticket is still in the "new" status)?
Unless 3-1-7 gets really released in the next few days?
Ok there are bugs in Singular but they were already here and should be dealt with other tickets.
Stucking with the current version we have prevent other packages to be updated (at least NTL).

jpflori · 2013-10-30T16:41:57Z

comment:24

Hum, #14333 comment:18 might need some investigation/work...

burcin · 2013-10-30T16:43:59Z

comment:25

Replying to @jpflori:

Hum, #14333 comment:18 might need some investigation/work...

That is probably caused by running Sage without rebuilding the library. sage -b should fix it.

jpflori · 2013-12-23T16:03:06Z

comment:26

It seems 3-1-7 is not out yet, so any other reason not to put that to needs_review Burcin?

burcin · 2013-12-23T19:14:46Z

comment:27

Replying to @jpflori:

It seems 3-1-7 is not out yet, so any other reason not to put that to needs_review Burcin?

I am switching to needs_review. Singular 4-0-0 was released on Friday. I don't know if they plan to make bug-fix releases on the 3-1 series any more.

As I wrote before, it would be a major effort to port the libsingular interface to 4-0-0. I don't have time to do that in the near future.

jpflori · 2013-12-23T19:19:51Z

comment:28

Replying to @burcin:

Replying to @jpflori:

It seems 3-1-7 is not out yet, so any other reason not to put that to needs_review Burcin?

I am switching to needs_review. Singular 4-0-0 was released on Friday. I don't know if they plan to make bug-fix releases on the 3-1 series any more.

Ok thanks for the details.
i may be dumb but once more I did not find anything on the singular website (or at least the first thing that Google pointed at) about 4-0-0.
Note that there is indeed something here:

http://www.mathematik.uni-kl.de/ftp/pub/Math/Singular/SOURCES/
Is there another hidden channel where annoucements are made?

As I wrote before, it would be a major effort to port the libsingular interface to 4-0-0. I don't have time to do that in the near future.

Ok, so let's go for the 3-1-x upgrade.
I'll port the latest spkg to the new layout.

jpflori · 2013-12-23T23:53:38Z

Branch: u/jpflori/ticket/14333

jpflori · 2013-12-23T23:53:38Z

comment:29

I'm ok with Burcin changes: it's mostly patches cleanup, integration of a few backported patches and modification for the new API as documented in the ticket description.
I also removed the description of old patches which was still there.

If someone could check I did not screw up the new layout transition I guess it can go in.
(Note that the version should be 3-1-6 but the new scripts don't support it when extraction version number, so as was done for 3-1-5, I put 3.1.6 everywhere.)

New commits:

`dd46991`	`Remove description of deleted patches.`
`536a31f`	`Update Singular function interface to API changes in Singular 3.1.6.`
`1753f06`	`Update Singular to version 3-1-6.`

jpflori · 2013-12-23T23:53:38Z

Reviewer: Jean-Pierre Flori

jpflori · 2013-12-23T23:53:38Z

Commit: dd46991

kiwifb · 2013-12-30T09:54:55Z

comment:30

Looks OK to me, we should get it in.

SnarkBoojum mannequin added this to the sage-5.11 milestone Mar 22, 2013

SnarkBoojum mannequin added c: packages: standard labels Mar 22, 2013