implements parking functions

[sagetrac-DorotaMazur]

Implements classes and methods related to parking functions

Apply

• attachment: 14086-parking_functions_rebased.patch

Depends on #8703
Depends on #14433

CC: @zabrocki @sagetrac-elixyre @hivert

Component: combinatorics

Keywords: Parking Function

Author: Dorota Mazur

Reviewer: Mike Zabrocki

Merged: sage-5.10.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14086

[zabrocki]

comment:1

Attachment: parking_functions-dm.patch.gz

Florent and Jean-Baptiste,
Can you take a look at this patch and make sure that it will be useful for implementing algebras like PQSym. Do you have any other feedback?
-Mike

[sagetrac-DorotaMazur]

comment:3

apply only trac_14086-parking_functions-dm.patch

[fchapoton]

comment:4

Hello, there seems to be an unused import:

sage/combinat/parking_functions.py:73: 'Composition' imported but unused

[fchapoton]

Work Issues: import

[fchapoton]

comment:6

sorry, this was already corrected in the second patch

[fchapoton]

comment:8

Hello,

you should not use

assert isinstance(n, (Integer, int)) and n >= 0, '%s is not a non-negative integer.' % n 

but rather write a test that raise a ValueError

Similar problem for all the other assert in your patch

[fchapoton]

comment:11

Well, nothing works..

You have made a mistake in changing one of the assert into a test (you forgot to add a not)

Please run sage -t to catch the errors, before posting patches here.

[sagetrac-DorotaMazur]

comment:12

I made changes, run the test. I hope it is working now.

[fchapoton]

comment:13

Hello,

things are starting to look good. I upload a first review patch.

[fchapoton]

comment:14

Attachment: trac_14086-parking-review-fc.patch.gz

[zabrocki]

comment:16

Dorota, the new version of your patch does not change the /doc/en/reference/combinat/index.rst file to insert the line sage/combinat/parking_functions. I think you will need to make this change.

[sagetrac-DorotaMazur]

Attachment: trac_14086-parking_functions-dm.patch.gz

Replying to @sagetrac-DorotaMazur:

Implements classes and methods related to parking functions

Apply

• attachment: trac_14086-parking_functions-dm.patch
• attachment: trac_14086-parking-review-fc.patch

[zabrocki]

comment:18

The patch trac_14086-parking-review-mz.patch makes a number of minor changes to the documentation and contains all of the changes from trac_14086-parking-review-fc.patch since it needed to rebased against the lastest version.

[zabrocki]

Attachment: trac_14086-parking-review-mz.patch.gz

[zabrocki]

comment:19

I think this is ready.

[jdemeyer]

Changed work issues from import to none

[jdemeyer]

Reviewer: Mike Zabrocki

[jdemeyer]

Merged: sage-5.10.beta0

[jdemeyer]

Attachment: 14086-parking_functions_rebased.patch.gz

[jdemeyer]

Dependencies: #8703, #14433