Provides some further functionalities for combinatorial maps

[stumpc5]

This patch provides some further functionalities for combinatorial maps.

CC: @sagetrac-chrisjamesberg @VivianePons

Component: combinatorics

Keywords: combinatorial map

Author: Christian Stump

Reviewer: Travis Scrimshaw

Merged: sage-5.9.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14255

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:2

Hey Christian,

Looks good but there's two minor docstring things. First is I don't understand this line 210 in unbounded_map():

This can then be used to be applied to an element.

Second (and more nitpicky and far less important), the first line is suppose to be in the "affirmative" according to python doc standards:

Return the unbounded..."

Thanks,

Travis

[stumpc5]

comment:3

Replying to @tscrim:

thanks for your review, Travis!

This can then be used to be applied to an element.

means that this is now an unbounded function and it takes one input parameter, namely self. How do you think I should write that?

Return the unbounded..."

alright, I will do that... (but first waiting for your answer to the above).

[tscrim]

comment:4

How does this sound:

You can use this method to return a function which takes as input an
element in the domain of the combinatorial map. See the example below.

? Also could you put another blank line between this and the "Return" line? Thank you.

[stumpc5]

Attachment: trac_14255-combinatorial_maps-cs.patch.gz

[stumpc5]

comment:5

Replying to @tscrim:

How does this sound:

You can use this method to return a function which takes as input an
element in the domain of the combinatorial map. See the example below.

? Also could you put another blank line between this and the "Return" line? Thank you.

Fixed, thanks!

[tscrim]

comment:6

Thank you Christian.

[jdemeyer]

Merged: sage-5.9.beta1