Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding combinatorial maps decorators to various combinatorial classes #14302

Closed
sagetrac-chrisjamesberg mannequin opened this issue Mar 19, 2013 · 10 comments
Closed

Adding combinatorial maps decorators to various combinatorial classes #14302

sagetrac-chrisjamesberg mannequin opened this issue Mar 19, 2013 · 10 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-5.10

Comments

@sagetrac-chrisjamesberg
Copy link
Mannequin

Looking to add combinatorial maps decorators to several combinatorial classes. This will also solve #14258 and #14259.

Depends on #14123
Depends on #14140
Depends on #14197
Depends on #14255
Depends on #8703

CC: @tscrim @stumpc5

Component: combinatorics

Keywords: combinatorial map

Author: Chris Berg

Reviewer: Christian Stump

Merged: sage-5.10.rc1

Issue created by migration from https://trac.sagemath.org/ticket/14302
@sagetrac-chrisjamesberg sagetrac-chrisjamesberg mannequin added this to the sage-5.10 milestone Mar 19, 2013
@sagetrac-chrisjamesberg
Copy link
Mannequin Author

Changed dependencies from 14123, 14140,14197, 14255,8703 to #14123, #14140, #14197, #14255, #8703

@sagetrac-chrisjamesberg

This comment has been minimized.

Sign in to view
@stumpc5
Copy link
Contributor

stumpc5 commented May 22, 2013

comment:3

I'd give it a positive review, but it says be be depending on #14302, which doesn't apply currently... I'll likely find the time to review both tomorrow.

@stumpc5
Copy link
Contributor

stumpc5 commented May 23, 2013

Author: Chris Berg

@stumpc5
Copy link
Contributor

stumpc5 commented May 23, 2013

comment:5

If anyone finds a min to rebase this patch: go ahead!

@stumpc5
Copy link
Contributor

stumpc5 commented May 24, 2013

Attachment: trac_14302_combinatorial_maps-rebase-cs.patch.gz

@stumpc5
Copy link
Contributor

stumpc5 commented May 24, 2013

Reviewer: Christian Stump

@stumpc5
Copy link
Contributor

stumpc5 commented May 24, 2013

Changed keywords from none to combinatorial map

@jdemeyer jdemeyer modified the milestones: sage-5.10, sage-5.11 May 27, 2013
@stumpc5
Copy link
Contributor

stumpc5 commented May 29, 2013

comment:8

Replying to @jdemeyer:

Dear Jeroen,

since you just merged #14123 into sage-5.10.rc0, I wonder if it would be a big deal to also merge this ticket. We have a workshop on www.FindStat.org in two weeks, and having this as well merged would make life a bit easier there.

Cheers, Christian

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.10 Jun 3, 2013
@jdemeyer
Copy link
Contributor

jdemeyer commented Jun 5, 2013

Merged: sage-5.10.rc1

@jdemeyer jdemeyer closed this as completed Jun 5, 2013
@tscrim tscrim mentioned this issue May 28, 2013
Closed
@stumpc5 stumpc5 mentioned this issue Nov 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-5.10
Development

No branches or pull requests
2 participants
@stumpc5 @jdemeyer