Symbolic spherical harmonic

[eviatarbach]

This ticket is for making spherical_harmonic a symbolic function.

CC: @burcin @kcrisman

Component: symbolics

Author: Eviatar Bach

Branch: 8588d16

Reviewer: Jan Keitel, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/15017

[eviatarbach]

Attachment: trac15017.patch.gz

[eviatarbach]

comment:1

Patchbot apply trac15017.patch

[eviatarbach]

comment:2

Attachment: trac15017_2.patch.gz

New patch gets coverage to 100% and fixes an issue in _eval_.

Patchbot apply trac15017_2.patch

[rwst]

comment:6

Patch does not merge.

[sagetrac-jkeitel]

Commit: ee464ee

[sagetrac-jkeitel]

Branch: u/jkeitel/15017

[sagetrac-jkeitel]

New commits:

ee464ee

Imported patch for making spherical harmonic symbolic.

[sagetrac-jkeitel]

comment:8

I've imported the patch and made one tiny change in _evalf_ to fix a couple of doctests.

[tscrim]

Changed branch from u/jkeitel/15017 to public/ticket/spherical_harmonic-15017

[tscrim]

Author: Eviatar Bach

[tscrim]

Changed commit from ee464ee to 8588d16

[tscrim]

comment:9

Some minor review tweaks from me, but if you're okay with them, then positive review.

---

New commits:

39565d2	Merge branch 'u/jkeitel/15017' of trac.sagemath.org:sage into public/ticket/spherical_harmonic-15017
8588d16	Minor review tweaks for spherical harmonic functions.

[tscrim]

Reviewer: Jan Keitel, Travis Scrimshaw

[kcrisman]

comment:10

Is 'Merzbacher' available online, so that we can do a real reference? Just wondering.

[eviatarbach]

comment:11

I think the citation was just copied from the Maxima documentation, which refers to Eugen Merzbacher Quantum Mechanics (2nd edition, 1970).

[sagetrac-jkeitel]

comment:12

Frankly, I can't make sense of that. What is 9.64 supposed to refer it? Surely not equation 9.64 in http://instrumentation.tamu.edu/~ting/other/QM_Merzbacher.pdf

Should we just remove the reference?

[eviatarbach]

comment:13

Fine with me.

[rwst]

comment:14

I gather this is now positive?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

872e2bc

Remove old reference from spherical harmonics.

[sagetrac-git]

Changed commit from 8588d16 to 872e2bc

[sagetrac-jkeitel]

comment:16

Well, now it is.

[vbraun]

Changed branch from public/ticket/spherical_harmonic-15017 to 872e2bc

[cheuberg]

Changed commit from 872e2bc to none

[cheuberg]

comment:18

Replying to @sagetrac-git:

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

872e2bc

Remove old reference from spherical harmonics.

This last commit has not been merged, see the discussion at
sage-devel. I opened a new ticket for that commit: #18218.

[cheuberg]

Changed branch from 872e2bc to 8588d16