Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement symbolic Stieltjes constants #19834

Closed
rwst opened this issue Jan 5, 2016 · 22 comments
Closed

implement symbolic Stieltjes constants #19834

rwst opened this issue Jan 5, 2016 · 22 comments

Comments

@rwst
Copy link
Contributor

rwst commented Jan 5, 2016

Probably just another symbolic function would suffice. This would be needed for zeta expansion and special values. The Sage side would be a new GinacFunction and numeric evaluation.

Depends on pynac/pynac#120
See also #18141.

Depends on #19948

CC: @behackl

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 0e1162b

Reviewer: Benjamin Hackl

Issue created by migration from https://trac.sagemath.org/ticket/19834

@rwst rwst added this to the sage-7.0 milestone Jan 5, 2016
@rwst

This comment has been minimized.

@rwst

This comment has been minimized.

@rwst

This comment has been minimized.

@behackl
Copy link
Member

behackl commented Jan 6, 2016

comment:5

For the sake of representation: should there be two separate functions, say stieltjes(n) and generalized_stieltjes(n, a) represented as \gamma_n and \gamma_n(a), respectively?

Of course, like stieltjes(0) should return euler_gamma, generalized_stieltjes(n, 1) should return stieltjes(n) -- but I think this can be done easily, either still in pynac, or after registering the function in sage.

@behackl
Copy link
Member

behackl commented Jan 6, 2016

comment:6

... or just stieltjes(n, a=1) with adaptive representation. That's probably more elegant. ;-)

@rwst
Copy link
Contributor Author

rwst commented Jan 7, 2016

@rwst
Copy link
Contributor Author

rwst commented Jan 7, 2016

Author: Ralf Stephan

@rwst
Copy link
Contributor Author

rwst commented Jan 7, 2016

comment:8

This is what Sage needs to use the current pynac git master implementation of Stieltjes constants (not generalized).


New commits:

bdac71f19834: implement symbolic Stieltjes constants

@rwst
Copy link
Contributor Author

rwst commented Jan 7, 2016

Commit: bdac71f

@rwst
Copy link
Contributor Author

rwst commented Jan 7, 2016

Dependencies: pynac-0.6.1

@videlec
Copy link
Contributor

videlec commented Jan 9, 2016

comment:9

Why are you making cdef object py_stieltjes a cdef function? A cdef function that takes as input a Python object, returns a Python object would and only contains Python code would better be a def function.

@videlec
Copy link
Contributor

videlec commented Jan 9, 2016

comment:10

Ho I see. This is actually needed for the array of functions.

@rwst
Copy link
Contributor Author

rwst commented Jan 10, 2016

comment:11

Yes, everything symbolic is rooted through Pynac, so ex.n() calls Pynac's evalf functions which call (indirectly) Python functions which therefore must be cdef.

@rwst
Copy link
Contributor Author

rwst commented Jan 24, 2016

Changed dependencies from pynac-0.6.1 to #19448

@rwst rwst modified the milestones: sage-7.0, sage-7.1 Jan 24, 2016
@rwst
Copy link
Contributor Author

rwst commented Jan 24, 2016

Changed dependencies from #19448 to #19948

@behackl
Copy link
Member

behackl commented Feb 4, 2016

comment:14

I just resolved the merge conflict with 7.1.beta1.


New commits:

0e1162bMerge tag '7.1.beta1' into symbolics/stieltjes-constants

@behackl
Copy link
Member

behackl commented Feb 4, 2016

Changed commit from bdac71f to 0e1162b

@behackl
Copy link
Member

behackl commented Feb 4, 2016

@behackl
Copy link
Member

behackl commented Feb 4, 2016

Reviewer: Benjamin Hackl

@behackl
Copy link
Member

behackl commented Feb 4, 2016

comment:15

Implementation looks fine to me; doctests pass. I'd still like to see if the patchbot is satisfied, too. I'll set this to positive_review later---or you can do so directly, if you do not want to wait. ;-)

@rwst
Copy link
Contributor Author

rwst commented Feb 4, 2016

comment:17

Thanks!

@vbraun
Copy link
Member

vbraun commented Feb 5, 2016

Changed branch from u/behackl/symbolics/stieltjes-constants to 0e1162b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants