Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pynac-0.6.1 #19948

Closed
rwst opened this issue Jan 23, 2016 · 16 comments
Closed

Upgrade to pynac-0.6.1 #19948

rwst opened this issue Jan 23, 2016 · 16 comments

Comments

@rwst
Copy link
Contributor

rwst commented Jan 23, 2016

Brand new pynac has:

Tarball: https://github.com/pynac/pynac/releases/download/pynac-0.6.1/pynac-0.6.1.tar.bz2

CC: @behackl

Component: packages: standard

Author: Ralf Stephan

Branch/Commit: 8a9b6ac

Reviewer: Benjamin Hackl

Issue created by migration from https://trac.sagemath.org/ticket/19948

@rwst rwst added this to the sage-7.1 milestone Jan 23, 2016
@jdemeyer

This comment has been minimized.

@rwst
Copy link
Contributor Author

rwst commented Jan 24, 2016

Branch: u/rws/upgrade_to_pynac_0_6_1

@rwst
Copy link
Contributor Author

rwst commented Jan 24, 2016

Author: Ralf Stephan

@rwst
Copy link
Contributor Author

rwst commented Jan 24, 2016

Commit: b76a8ad

@rwst
Copy link
Contributor Author

rwst commented Jan 24, 2016

New commits:

5c8814119448: update Pynac pkg data
b76a8ad19948: add stieltjes() interface; fix doctest

@behackl
Copy link
Member

behackl commented Jan 24, 2016

comment:4

Interface and doctest changes LGTM; currently running ptestlong.

@jdemeyer
Copy link
Contributor

comment:5

Should this be ValueError?

raise AttributeError("Stieltjes constant of negative index")

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

485740219949: fix type of error raised by stieltjes()

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2016

Changed commit from b76a8ad to 4857402

@rwst
Copy link
Contributor Author

rwst commented Jan 24, 2016

comment:7

You're right.

@behackl
Copy link
Member

behackl commented Jan 24, 2016

comment:8

Sorry, missed the error type. In any case:

ptestlong passes on two separate machines. Would be positive_review from my side.

@jdemeyer
Copy link
Contributor

Reviewer: Benjamin Hackl

@jdemeyer
Copy link
Contributor

@jdemeyer
Copy link
Contributor

comment:11

The ticket number in 2 of the 3 commit messages was wrong. I squashed the commits and fixed the commit message.


New commits:

8a9b6acTrac #19948: Upgrade to pynac-0.6.1

@jdemeyer
Copy link
Contributor

Changed commit from 4857402 to 8a9b6ac

@vbraun
Copy link
Member

vbraun commented Jan 28, 2016

Changed branch from u/jdemeyer/upgrade_to_pynac_0_6_1 to 8a9b6ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants