doctest fix for infinities break the hash contract

[rwst]

sage: hash(-oo)
-9223372036854775808
sage: hash(SR(-oo))
1390175631
sage: hash(oo)
9223372036854775807
sage: hash(SR(oo))
1577573780
sage: hash(unsigned_infinity)
9223372036854775806
sage: hash(SR(unsigned_infinity))
2904791665

Fixed in pynac/pynac#126

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 9eb6d88

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19928

[rwst]

Dependencies: #19927

[rwst]

comment:1

#19927 has to be fixed in Sage before Pynac can copy hash values from there.

[rwst]

Changed dependencies from #19927 to none

[rwst]

Upstream: Fixed upstream, in a later stable release.

[rwst]

comment:6

It's fixed now and just needs to be doctested.

[rwst]

Changed upstream from Fixed upstream, in a later stable release. to none

[rwst]

Branch: u/rws/doctest_fix_for_infinities_break_the_hash_contract

[rwst]

Author: Ralf Stephan

[rwst]

New commits:

62cd611

19928: doctest fix for infinities break the hash contract

[rwst]

Commit: 62cd611

[tscrim]

comment:9

This is more towards bikeshedding, but I don't quite understand why you switched the tests to use assert instead of letting the doctest framework do its usual work. I feel that the previous tests were (marginally) more clear.

[jdemeyer]

comment:10

Replying to @tscrim:

This is more towards bikeshedding, but I don't quite understand why you switched the tests to use assert instead of letting the doctest framework do its usual work. I feel that the previous tests were (marginally) more clear.

+1

[rwst]

Changed branch from u/rws/doctest_fix_for_infinities_break_the_hash_contract to u/rws/19928

[rwst]

New commits:

9eb6d88

19928: doctest fix for infinities break the hash contract

[rwst]

Changed commit from 62cd611 to 9eb6d88

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/rws/19928 to 9eb6d88