Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new style package for qhull #21143

Closed
videlec opened this issue Aug 1, 2016 · 19 comments
Closed

new style package for qhull #21143

videlec opened this issue Aug 1, 2016 · 19 comments

Comments

@videlec
Copy link
Contributor

videlec commented Aug 1, 2016

The branch turns qhull into a new style package (and updates it to the most recent version).

Upstream tarball at

http://www.qhull.org/download/qhull-2015-src-7.2.0.tgz

see also: #19220

Upstream: Reported upstream. Developers acknowledge bug.

Component: packages: optional

Author: Vincent Delecroix

Branch/Commit: 6fc873d

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/21143

@videlec videlec added this to the sage-7.3 milestone Aug 1, 2016
@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented Aug 1, 2016

New commits:

20af0fc21143: new style package for qhull

@videlec
Copy link
Contributor Author

videlec commented Aug 1, 2016

Branch: u/vdelecroix/21143

@videlec
Copy link
Contributor Author

videlec commented Aug 1, 2016

Commit: 20af0fc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fcc68c521143: new style package for qhull

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2016

Changed commit from 20af0fc to fcc68c5

@videlec
Copy link
Contributor Author

videlec commented Aug 1, 2016

comment:4

(I reported upstream with respect to the patch)

@videlec
Copy link
Contributor Author

videlec commented Aug 1, 2016

Upstream: Reported upstream. No feedback yet.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 2, 2016

comment:5

It builds fine for me on Mac OS X.

An answer to an Ask SageMath question here claims that qhull is included with scipy: http://ask.sagemath.org/question/10254/how-does-one-use-the-qhull-optional-package/

Also there is this ticket: #12352

@videlec
Copy link
Contributor Author

videlec commented Aug 3, 2016

comment:6

Replying to @mkoeppe:

It builds fine for me on Mac OS X.

An answer to an Ask SageMath question here claims that qhull is included with scipy: http://ask.sagemath.org/question/10254/how-does-one-use-the-qhull-optional-package/

Indeed

But scipy does not seem to ship the binaries... But however their interface is pretty good and that's actually what we should use!

Also there is this ticket: #12352

which is rather disjoint.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 3, 2016

comment:7

Replying to @videlec:

Replying to @mkoeppe:

It builds fine for me on Mac OS X.

An answer to an Ask SageMath question here claims that qhull is included with scipy: http://ask.sagemath.org/question/10254/how-does-one-use-the-qhull-optional-package/

Indeed

But scipy does not seem to ship the binaries... But however their interface is pretty good and that's actually what we should use!

Right, for polymake (#20892) we do need the binaries.
Could you update the SPKG.txt to include info about scipy?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 3, 2016

Changed commit from fcc68c5 to 6fc873d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 3, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

6fc873d21143: mention scipy and Pyhull in SPKG.txt

@videlec
Copy link
Contributor Author

videlec commented Aug 3, 2016

comment:9

done

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 3, 2016

Reviewer: Matthias Koeppe

@videlec
Copy link
Contributor Author

videlec commented Aug 3, 2016

comment:11

Thanks!

@videlec videlec modified the milestones: sage-7.3, sage-7.4 Aug 3, 2016
@videlec
Copy link
Contributor Author

videlec commented Aug 4, 2016

Changed upstream from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

@videlec
Copy link
Contributor Author

videlec commented Aug 4, 2016

comment:13

for info: got a reply from upstream (Brad Barber). The next version of the Makefile will contain the target dependencies and there will be a configurable make install. However, it seems hard to get a configure to work on all platforms...

@vbraun
Copy link
Member

vbraun commented Aug 7, 2016

Changed branch from u/vdelecroix/21143 to 6fc873d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants